From: Andi Kleen <ak@suse.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: "Luck, Tony" <tony.luck@intel.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Andi Kleen <ak@novell.com>,
Arthur Jones <arthur.jones@qlogic.com>,
Vasily Tarasov <vtaras@openvz.org>,
linux-kernel@vger.kernel.org, Jan Kara <jack@ucw.cz>,
linux-arch@vger.kernel.org
Subject: Re: build fix for x86_64...
Date: Fri, 20 Jul 2007 19:25:11 +0200 [thread overview]
Message-ID: <200707201925.12036.ak@suse.de> (raw)
In-Reply-To: <46A0EAC8.9020203@zytor.com>
On Friday 20 July 2007 19:03, H. Peter Anvin wrote:
> Luck, Tony wrote:
> > Which is better. But if we unconditionally set this CONFIG variable,
> > then the code in fs/quota.c will have to read:
> >
> > #if defined(CONFIG_COMPAT) && defined(CONFIG_COMPAT_FOR_U64_ALIGNMENT)
> >
> > We can keep it simpler if the Kconfig file does the conditional for us:
> >
> > config COMPAT_FOR_U64_ALIGNMENT
> > def_bool y
> > depends on COMPAT
>
> No, that would be bad. If compat_u64 is used to carry 32-bit ABIs
That doesn't help for any old interfaces, like the one here. For those
still ifdefs are needed. Interfaces that use compat_u64 just use
a normal #ifdef CONFIG_COMPAT.
Besides I have my doubts compat_u64 will be the solution
to these worries. We have hundreds of people adding various interfaces
to Linux and it's unlikely they all heard about it. So likely
these cases will occur again and again.
-Andi
next prev parent reply other threads:[~2007-07-20 17:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-19 22:24 build fix for x86_64 Arthur Jones
2007-07-19 23:09 ` Andi Kleen
2007-07-19 23:54 ` Luck, Tony
2007-07-20 8:32 ` Andi Kleen
2007-07-20 15:55 ` Randy Dunlap
2007-07-20 16:20 ` Luck, Tony
2007-07-20 16:48 ` Matthew Wilcox
2007-07-20 17:03 ` H. Peter Anvin
2007-07-20 17:25 ` Andi Kleen [this message]
2007-07-20 17:38 ` H. Peter Anvin
2007-07-20 17:40 ` Andreas Schwab
2007-07-20 17:45 ` H. Peter Anvin
2007-07-20 18:13 ` Andi Kleen
2007-07-20 19:29 ` H. Peter Anvin
2007-07-20 22:08 ` Luck, Tony
2007-07-20 22:34 ` H. Peter Anvin
2007-07-20 18:27 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707201925.12036.ak@suse.de \
--to=ak@suse.de \
--cc=ak@novell.com \
--cc=arthur.jones@qlogic.com \
--cc=hpa@zytor.com \
--cc=jack@ucw.cz \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=tony.luck@intel.com \
--cc=vtaras@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox