Re: drivers/edac: add mips and ppc visibility

Re: drivers/edac: add mips and ppc visibility

[Dave Jones]

On Thu, Jul 19, 2007 at 05:59:16PM +0000, Linux Kernel wrote:
 > Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=b113a3f7e85d7f97c8383a88a5bc7c2ea8daeb2f
 > Commit:     b113a3f7e85d7f97c8383a88a5bc7c2ea8daeb2f
 > Parent:     052dfb45ccb5ea354a426b52556bcfee75b9d2f5
 > Author:     Douglas Thompson <dougthompson@xmission.com>
 > AuthorDate: Thu Jul 19 01:50:15 2007 -0700
 > Committer:  Linus Torvalds <torvalds@woody.linux-foundation.org>
 > CommitDate: Thu Jul 19 10:04:55 2007 -0700
 > 
 >     drivers/edac: add mips and ppc visibility
 >     
 >     1) Remove an old CVS ID string
 >     
 >     2) change EDAC from a tristate option to a simple bool option
 >     
 >     3) In addition to the X86 arch, PPC and MIPS also have drivers in the
 >     submission queue.  This patch turns on the EDAC flag for those archs.  Each
 >     driver will have its respective 'depends on ARCH' set.
 >     
 >     Signed-off-by: Douglas Thompson <dougthompson@xmission.com>
 >     Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
 >     Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
 >     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

What was the reasoning behind 2) ?
Now everyone's distro kernel has bits of EDAC in it even if they
don't use it.  (Admittedly only a small amount, but these things
tend to creep in bit by bit).

	Dave

-- 
http://www.codemonkey.org.uk

Re: drivers/edac: add mips and ppc visibility

[Doug Thompson]

--- Dave Jones <davej@redhat.com> wrote:

> On Thu, Jul 19, 2007 at 05:59:16PM +0000, Linux Kernel wrote:
>  > Gitweb:    
>
http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=b113a3f7e85d7f97c8383a88a5bc7c2ea8daeb2f
>  > Commit:     b113a3f7e85d7f97c8383a88a5bc7c2ea8daeb2f
>  > Parent:     052dfb45ccb5ea354a426b52556bcfee75b9d2f5
>  > Author:     Douglas Thompson <dougthompson@xmission.com>
>  > AuthorDate: Thu Jul 19 01:50:15 2007 -0700
>  > Committer:  Linus Torvalds <torvalds@woody.linux-foundation.org>
>  > CommitDate: Thu Jul 19 10:04:55 2007 -0700
>  > 
>  >     drivers/edac: add mips and ppc visibility
>  >     
>  >     1) Remove an old CVS ID string
>  >     
>  >     2) change EDAC from a tristate option to a simple bool option
>  >     
>  >     3) In addition to the X86 arch, PPC and MIPS also have drivers in the
>  >     submission queue.  This patch turns on the EDAC flag for those archs.  Each
>  >     driver will have its respective 'depends on ARCH' set.
>  >     
>  >     Signed-off-by: Douglas Thompson <dougthompson@xmission.com>
>  >     Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
>  >     Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>  >     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> 
> What was the reasoning behind 2) ?
> Now everyone's distro kernel has bits of EDAC in it even if they
> don't use it.  (Admittedly only a small amount, but these things
> tend to creep in bit by bit).
> 
> 	Dave

It might be my failed understanding, but the requested patch for this, was to move the
ON/OFF of EDAC into the 'drivers' submenu directly (instead of down in the EDAC submenu), 
to allow for faster disabling/enabling of EDAC in menuconfig.

But all the modules are still tri-state configured.

If I am missing something here, please give me some needed instruction. From what I understand
your comment, the code is can still be configured in modules.

thanks

doug t


> 
> -- 
> http://www.codemonkey.org.uk
>