From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934351AbXGTUG0 (ORCPT ); Fri, 20 Jul 2007 16:06:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757636AbXGTUGT (ORCPT ); Fri, 20 Jul 2007 16:06:19 -0400 Received: from mx1.redhat.com ([66.187.233.31]:40019 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755191AbXGTUGS (ORCPT ); Fri, 20 Jul 2007 16:06:18 -0400 Date: Fri, 20 Jul 2007 16:05:30 -0400 From: Dave Jones To: Al Viro Cc: Linus Torvalds , Mike Christie , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Andy Whitcroft Subject: Re: [PATCH] buggered kmalloc() Message-ID: <20070720200530.GA9978@redhat.com> Mail-Followup-To: Dave Jones , Al Viro , Linus Torvalds , Mike Christie , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Andy Whitcroft References: <20070720150340.GF21668@ftp.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070720150340.GF21668@ftp.linux.org.uk> User-Agent: Mutt/1.5.14 (2007-02-12) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 20, 2007 at 04:03:40PM +0100, Al Viro wrote: > Signed-off-by: Al Viro > --- > diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c > index aebcd5f..7829ab1 100644 > --- a/drivers/scsi/iscsi_tcp.c > +++ b/drivers/scsi/iscsi_tcp.c > @@ -1885,7 +1885,7 @@ static int iscsi_tcp_get_addr(struct iscsi_conn *conn, struct socket *sock, > struct sockaddr_in *sin; > int rc = 0, len; > > - addr = kmalloc(GFP_KERNEL, sizeof(*addr)); > + addr = kmalloc(sizeof(*addr), GFP_KERNEL); > if (!addr) > return -ENOMEM; This seems like something that would be trivial to check for in checkpatch. Dave -- http://www.codemonkey.org.uk