Re: [PATCH] compat_ioctl requires CONFIG_BLOCK

[Arnd Bergmann <arnd@arndb.de>]

On Saturday 21 July 2007, Sebastian Siewior wrote:
> 
> Got with randconfig
> include/linux/loop.h:66: error: expected specifier-qualifier-list before
> 'request_queue_t'
> make[1]: *** [fs/compat_ioctl.o] Error 1
> 
> parts of compat ioctl require CONFIG_BLOCK to be set.
> 
> Signed-off-by: Sebastian Siewior <sebastian@breakpoint.cc>
> Index: b/fs/compat_ioctl.c
> ===================================================================
> --- a/fs/compat_ioctl.c
> +++ b/fs/compat_ioctl.c
> @@ -63,7 +63,9 @@
>  #include <linux/wireless.h>
>  #include <linux/atalk.h>
>  #include <linux/blktrace_api.h>
> +#ifdef CONFIG_BLOCK
>  #include <linux/loop.h>
> +#endif

Adding #ifdef around an #include is considered bad style. Better just
make loop.h compile without any conditionals. Does the below
patch work for you?

	Arnd <><

--- a/include/linux/loop.h
+++ b/include/linux/loop.h
@@ -63,7 +63,7 @@ struct loop_device {
 	struct task_struct	*lo_thread;
 	wait_queue_head_t	lo_event;
 
-	request_queue_t		*lo_queue;
+	struct request_queue	*lo_queue;
 	struct gendisk		*lo_disk;
 	struct list_head	lo_list;
 };