Re: [RFC, Announce] Unified x86 architecture, arch/x86

Matt Mackall
2007-07-22T12:04:05Z

On Sun, Jul 22, 2007 at 09:50:46AM +0200, Thomas Gleixner wrote:
> On Sat, 2007-07-21 at 16:51 -0700, Chris Wright wrote:
> > * Matt Mackall (mpm@selenic.com) wrote:
> > > Can we see some stats on:
> > >
> > > How many files were auto-merged?
> > > How many files got 32.c and 64.c extensions?
> > > How many existed only in one arch?
> >
> > It's mostly about file movement first.
> >
> > 918 files changed, 4745 insertions(+), 2836 deletions(-)
>
> Hmm, did you forget to make distclean ?
>
> Numbers from the script:
>
> include/asm-i386 240 files
> include/asm-x86_64 169 files
> ------------------------------
> 409 files
>
> include/asm-x86 389 files
>
> arch/i386 335 files
> arch/x86_64 141 files
> ------------------------------
> 476 files
>
> arch/x86 484 files
>
> The increase here is due to migration helper files which only include
> the (_32.x or the _64.x) variant.
>
> Makefile helpers 9 files
> Kconfig helpers 1 file
> Source helpers 4 files
> ------------------------------
> 14 files
>
> Summary:
> vanilla 22657 files
> vanilla->x86 22649 files
>
> ------------------------------
>
> include/x86 has 125 _32 and 125 _64 files
> arch/x86 has 55 _32 and 55 _64 files
>
> 25 files were auto-merged
>
> Looking at include/asm-x86/*_[32/64].h there are offhand ~ 50 of the 125
> which differ only minimal (white space damage, comment changes, ...),
> where the unification is a no brainer.

That looks more promising than I would have expected. For what it's
worth, I was originally fairly disgusted by the _32/64.c thing, but
the idea grows on me.

--
Mathematics is the supreme nostalgia of our time.