From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S935347AbXGUI3J@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S935347AbXGUI3J (ORCPT <rfc822;w@1wt.eu>);
	Sat, 21 Jul 2007 04:29:09 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761217AbXGUI2l
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Sat, 21 Jul 2007 04:28:41 -0400
Received: from mail.suse.de ([195.135.220.2]:42859 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1760090AbXGUI2j (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 21 Jul 2007 04:28:39 -0400
From: Andi Kleen <ak@suse.de>
Organization: SUSE Linux Products GmbH, Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
To: "Yinghai Lu" <yhlu.kernel@gmail.com>
Subject: Re: [PATCH] x86_64: use apic core id bits for core nums
Date: Sat, 21 Jul 2007 10:22:47 +0200
User-Agent: KMail/1.9.6
Cc: "Andrew Morton" <akpm@linux-foundation.org>, joachim.deguara@amd.com,
       linux-kernel@vger.kernel.org
References: <86802c440707210056s745d44f1jc6437064741299eb@mail.gmail.com>
In-Reply-To: <86802c440707210056s745d44f1jc6437064741299eb@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200707211022.47859.ak@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Saturday 21 July 2007 09:56:15 Yinghai Lu wrote:
> please check my version, we should use core id bits instead.
> 
> it should replace
> [PATCH for review] [37/48] x86_64: make k8topology multi-core aware

Yes, you're right the patch is not good. It should probably use 
information from the regular CPU setup code, not touch cpuid
directly

I'll drop it for now

-Andi