From: Andi Kleen <ak@suse.de>
To: "Yinghai Lu" <yhlu.kernel@gmail.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
joachim.deguara@amd.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86_64: use apic core id bits for core nums
Date: Sat, 21 Jul 2007 14:28:46 +0200 [thread overview]
Message-ID: <200707211428.46711.ak@suse.de> (raw)
In-Reply-To: <86802c440707210421h33a4fa50n9856bfe95e5b386f@mail.gmail.com>
On Saturday 21 July 2007 13:21:34 Yinghai Lu wrote:
> On 7/21/07, Andi Kleen <ak@suse.de> wrote:
> > On Saturday 21 July 2007 09:56:15 Yinghai Lu wrote:
> > > please check my version, we should use core id bits instead.
> > >
> > > it should replace
> > > [PATCH for review] [37/48] x86_64: make k8topology multi-core aware
> >
> > Yes, you're right the patch is not good. It should probably use
> > information from the regular CPU setup code, not touch cpuid
> > directly
>
> need move some code into early_identify_cpu from identify_cpu in
> arch/x86_64/kernel/setup.c
> then could use that bits in bsp cpu info.
Yes something like this
> BTW:
> it seems for BSP only early_identify_cpu is called, and identify_cpu
> is only use in smp_callin for AP. Do i miss sth.
identify_cpu calls early_identify_cpu as first thing.
-Andi
next prev parent reply other threads:[~2007-07-21 12:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-21 7:56 [PATCH] x86_64: use apic core id bits for core nums Yinghai Lu
2007-07-21 8:22 ` Andi Kleen
2007-07-21 11:21 ` Yinghai Lu
2007-07-21 12:28 ` Andi Kleen [this message]
2007-07-22 1:36 ` Yinghai Lu
2007-07-23 19:20 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707211428.46711.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=joachim.deguara@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox