From: Arnd Bergmann <arnd@arndb.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: Sebastian Siewior <sebastian@breakpoint.cc>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] compat_ioctl requires CONFIG_BLOCK
Date: Sat, 21 Jul 2007 15:17:14 +0200 [thread overview]
Message-ID: <200707211517.15736.arnd@arndb.de> (raw)
In-Reply-To: <20070721124418.GA23802@infradead.org>
On Saturday 21 July 2007, Christoph Hellwig wrote:
>
> > Adding #ifdef around an #include is considered bad style. Better just
> > make loop.h compile without any conditionals. Does the below
> > patch work for you?
>
> That patch looks good, but even better would be adding a compat_ioctl
> handler to the loop driver. IIRC you even have an old patch for that
No, that doesn't fly in this case. The loop driver actually has a
compat_ioctl method, but the problem is that some tools try to
call this ioctl on devices other than loop.
We could of course add a fallback handler to compat_blkdev_ioctl(),
but I'm not convinced that this is better than the IGNORE_IOCTL
helper, unless we eventually move all of fs/compat_ioctl.c into
drivers.
Arnd <><
next prev parent reply other threads:[~2007-07-21 13:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-20 22:58 [PATCH] compat_ioctl requires CONFIG_BLOCK Sebastian Siewior
2007-07-20 23:08 ` Arnd Bergmann
2007-07-21 8:40 ` Sebastian Siewior
2007-07-21 12:44 ` Christoph Hellwig
2007-07-21 13:17 ` Arnd Bergmann [this message]
2007-07-24 0:23 ` Andrew Morton
2007-07-24 6:51 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707211517.15736.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox