From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932699AbXGUUFd (ORCPT ); Sat, 21 Jul 2007 16:05:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759886AbXGUUF0 (ORCPT ); Sat, 21 Jul 2007 16:05:26 -0400 Received: from lixom.net ([66.141.50.11]:44406 "EHLO mail.lixom.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757203AbXGUUFZ (ORCPT ); Sat, 21 Jul 2007 16:05:25 -0400 Date: Sat, 21 Jul 2007 15:18:37 -0500 From: Olof Johansson To: Andrew Morton Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-pcmcia@lists.infradead.org, linuxppc-dev@ozlabs.org, miltonm@bga.com Subject: Re: [PATCH v3] pcmcia: CompactFlash driver for PA Semi Electra boards Message-ID: <20070721201837.GA17814@lixom.net> References: <20070625010311.GA31355@lixom.net> <20070625171221.GA6684@lixom.net> <20070625193909.GA26021@infradead.org> <20070625204341.GA8865@lixom.net> <20070705144914.GA14284@lixom.net> <20070720164823.95608e43.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070720164823.95608e43.akpm@linux-foundation.org> User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 20, 2007 at 04:48:23PM -0700, Andrew Morton wrote: > > Who's maintaining PCMCIA? MAINTAINERS only lists a mailing list, no person. Seems > > weird for a component that's marked as maintained. > > Dominik Brodowski. He's having a bit of downtime at present (exams, I > think). He expects to return. Meanwhile, cc'ing me usually has some > effect. Thanks! > > +static const char driver_name[] = "electra-cf"; > > > > ... > > > > +static struct of_device_id electra_cf_match[] = > > +{ > > + { > > + .compatible = "electra-cf", > > + }, > > + {}, > > +}; > > Could have reused driver_name[] here, if that was appropriate. Driver name and device tree compatible field is not neccessarily the same, even though they do coincide here. > > --- mainline.orig/arch/powerpc/platforms/pasemi/setup.c > > +++ mainline/arch/powerpc/platforms/pasemi/setup.c > > I never know who maintains random-scruffy-ppc code like this. From a peek > in the git-whatchanged output, it appears to be yourself. Check the top of the file. :) (Kumar started doing that, I kept it up, seems useful). And yes, we do tend to have per-platform maintainers on ppc. > Have a few little fixies: Thanks! Acked-by: Olof Johansson > --- a/drivers/pcmcia/electra_cf.c~pcmcia-compactflash-driver-for-pa-semi-electra-boards-fix > +++ a/drivers/pcmcia/electra_cf.c [...]