From: Andrew Morton <akpm@linux-foundation.org>
To: Charlie Shepherd <masterdriverz@gentoo.org>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org,
torvalds@linux-foundation.org
Subject: Re: [PATCH] Remove unused variable 'start'.
Date: Sat, 21 Jul 2007 23:04:24 -0700 [thread overview]
Message-ID: <20070721230424.dc0cf5ab.akpm@linux-foundation.org> (raw)
In-Reply-To: <11850424083434-git-send-email-masterdriverz@gentoo.org>
On Sat, 21 Jul 2007 20:26:47 +0200 Charlie Shepherd <masterdriverz@gentoo.org> wrote:
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 3cee76a..5e7daea 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -72,7 +72,6 @@ void unmap_kernel_range(unsigned long addr, unsigned long size)
> {
> pgd_t *pgd;
> unsigned long next;
> - unsigned long start = addr;
> unsigned long end = addr + size;
>
> BUG_ON(addr >= end);
> @@ -84,7 +83,7 @@ void unmap_kernel_range(unsigned long addr, unsigned long size)
> continue;
> vunmap_pud_range(pgd, addr, next);
> } while (pgd++, addr = next, addr != end);
> - flush_tlb_kernel_range(start, end);
> + flush_tlb_kernel_range(addr, end);
> }
>
> static void unmap_vm_area(struct vm_struct *area)
err, no. addr has a different value here.
There's a patch in Andi's tree which fixes the compile warning.
prev parent reply other threads:[~2007-07-22 6:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-21 18:26 [PATCH] Remove unused variable 'start' Charlie Shepherd
2007-07-21 18:26 ` [PATCH] Remove 'isdn_* is defined but unused' warnings Charlie Shepherd
2007-07-22 6:04 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070721230424.dc0cf5ab.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masterdriverz@gentoo.org \
--cc=torvalds@linux-foundation.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox