[PATCH] Remove unused variable 'start'.

[PATCH] Remove unused variable 'start'.

[Charlie Shepherd]

Signed-off-by: Charlie Shepherd <masterdriverz@gentoo.org>
---
 mm/vmalloc.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 3cee76a..5e7daea 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -72,7 +72,6 @@ void unmap_kernel_range(unsigned long addr, unsigned long size)
 {
 	pgd_t *pgd;
 	unsigned long next;
-	unsigned long start = addr;
 	unsigned long end = addr + size;
 
 	BUG_ON(addr >= end);
@@ -84,7 +83,7 @@ void unmap_kernel_range(unsigned long addr, unsigned long size)
 			continue;
 		vunmap_pud_range(pgd, addr, next);
 	} while (pgd++, addr = next, addr != end);
-	flush_tlb_kernel_range(start, end);
+	flush_tlb_kernel_range(addr, end);
 }
 
 static void unmap_vm_area(struct vm_struct *area)
-- 
1.5.2.2

[PATCH] Remove 'isdn_* is defined but unused' warnings

[Charlie Shepherd]

Move the #ifdef guard above these functions to remove the warnings.

Signed-off-by: Charlie Shepherd <masterdriverz@gentoo.org>
---
 drivers/isdn/divert/divert_procfs.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/isdn/divert/divert_procfs.c b/drivers/isdn/divert/divert_procfs.c
index be77ee6..559a0d0 100644
--- a/drivers/isdn/divert/divert_procfs.c
+++ b/drivers/isdn/divert/divert_procfs.c
@@ -70,6 +70,8 @@ put_info_buffer(char *cp)
 	wake_up_interruptible(&(rd_queue));
 }				/* put_info_buffer */
 
+#ifdef CONFIG_PROC_FS
+
 /**********************************/
 /* deflection device read routine */
 /**********************************/
@@ -253,8 +255,6 @@ isdn_divert_ioctl(struct inode *inode, struct file *file,
 	return copy_to_user((void __user *)arg, &dioctl, sizeof(dioctl)) ? -EFAULT : 0;
 }				/* isdn_divert_ioctl */
 
-
-#ifdef CONFIG_PROC_FS
 static const struct file_operations isdn_fops =
 {
 	.owner          = THIS_MODULE,
-- 
1.5.2.2

Re: [PATCH] Remove unused variable 'start'.

[Andrew Morton]

On Sat, 21 Jul 2007 20:26:47 +0200 Charlie Shepherd <masterdriverz@gentoo.org> wrote:

> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 3cee76a..5e7daea 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -72,7 +72,6 @@ void unmap_kernel_range(unsigned long addr, unsigned long size)
>  {
>  	pgd_t *pgd;
>  	unsigned long next;
> -	unsigned long start = addr;
>  	unsigned long end = addr + size;
>  
>  	BUG_ON(addr >= end);
> @@ -84,7 +83,7 @@ void unmap_kernel_range(unsigned long addr, unsigned long size)
>  			continue;
>  		vunmap_pud_range(pgd, addr, next);
>  	} while (pgd++, addr = next, addr != end);
> -	flush_tlb_kernel_range(start, end);
> +	flush_tlb_kernel_range(addr, end);
>  }
>  
>  static void unmap_vm_area(struct vm_struct *area)

err, no.  addr has a different value here.

There's a patch in Andi's tree which fixes the compile warning.