Re: Linus 2.6.23-rc1

Andi Kleen
2007-07-22T22:22:25Z

On Monday 23 July 2007 00:10:01 Andre Noll wrote:
> On 14:04, Linus Torvalds wrote:
>
> > So give it all a good whacking, and report back about all the neat new
> > features!
>
> Does overlapping sections count as a new feature? ;)
>
> gcc -m elf_x86_64 -nostdlib -fPIC -shared -Wl,-soname=linux-vdso.so.1 -Wl,-z,max-page-size=4096 -Wl,-z,common-page-size=4096 -Wl,-T,arch/x86_64/vdso/vdso.lds arch/x86_64/vdso/vdso-start.o arch/x86_64/vdso/vdso-note.o arch/x86_64/vdso/vclock_gettime.o arch/x86_64/vdso/vgetcpu.o arch/x86_64/vdso/vvar.o -o arch/x86_64/vdso/vdso.so
> /usr/bin/ld: section .text [ffffffffff700500 -> ffffffffff7007e3] overlaps section .gnu.version_d [ffffffffff7004d8 -> ffffffffff70050f]
> collect2: ld returned 1 exit status
> make[3]: *** [arch/x86_64/vdso/vdso.so] Error 1
> make[2]: *** [arch/x86_64/vdso] Error 2
> make[1]: *** [_all] Error 2
> make: *** [all] Error 2

Does this patch fix it?

-Andi

Increase VDSO_TEXT_OFFSET for ancient binutils

For some reason old binutils genertate larger headers so
increase the text offset of the vdso to avoid linker errors.

Signed-off-by: Andi Kleen <ak@suse.de>

Index: linux/arch/x86_64/vdso/voffset.h
===================================================================
--- linux.orig/arch/x86_64/vdso/voffset.h
+++ linux/arch/x86_64/vdso/voffset.h
@@ -1 +1 @@
-#define VDSO_TEXT_OFFSET 0x500
+#define VDSO_TEXT_OFFSET 0x600