Re: Linus 2.6.23-rc1, xen fix

Ingo Molnar
2007-07-23T15:53:04Z

Subject: xen: fix process_msg() use-after-kfree
From: Ingo Molnar <mingo@elte.hu>

fix an obvious use-after-kfree bug in Xen.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
drivers/xen/xenbus/xenbus_xs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/xen/xenbus/xenbus_xs.c
===================================================================
--- linux.orig/drivers/xen/xenbus/xenbus_xs.c
+++ linux/drivers/xen/xenbus/xenbus_xs.c
@@ -782,8 +782,8 @@ static int process_msg(void)
msg->u.watch.vec = split(body, msg->hdr.len,
&msg->u.watch.vec_size);
if (IS_ERR(msg->u.watch.vec)) {
- kfree(msg);
err = PTR_ERR(msg->u.watch.vec);
+ kfree(msg);
goto out;
}