From: Sam Ravnborg <sam@ravnborg.org>
To: Roland McGrath <roland@redhat.com>
Cc: David Miller <davem@davemloft.net>, Adrian Bunk <bunk@stusta.de>,
linux-kernel@vger.kernel.org
Subject: Re: "build-id" changes break sparc64
Date: Mon, 23 Jul 2007 08:22:25 +0200 [thread overview]
Message-ID: <20070723062224.GA3933@uranus.ravnborg.org> (raw)
In-Reply-To: <20070723060155.2B3824D0489@magilla.localdomain>
On Sun, Jul 22, 2007 at 11:01:55PM -0700, Roland McGrath wrote:
> It turns out the problem here is that some .o files wind up with their own
> .note.gnu.build-id sections. I got the makefile magic wrong, thinking that
> LDFLAGS_MODULE was a variable specifically for .ko links.
Reading Documentation/kbuild/makefiles.txt:
LDFLAGS_MODULE Options for $(LD) when linking modules
LDFLAGS_MODULE is used to set specific flags for $(LD) when
linking the .ko files used for modules.
So it seems to be documented as such.
Browsing the source it looks like a bug that LDFLAGS_MODULE is used in
cmd_link_multi-m.
I suggest you to do the following:
Remove '-r' from LDFLAGS_MODULE in top-level Makefile
Hardcode '-r' in cmd_link_multi-m and remove LDFLAGS_MODULE in the same.
Hardcode '-r' in Makefile,modpost
Add your stuff to LDFLAGS_MODULE in toplevel Makefile.
Sorry for not prrviding a preliminary patch but away from my dev box
with no easy source access.
Sam
prev parent reply other threads:[~2007-07-23 6:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-22 8:23 "build-id" changes break sparc64 David Miller
2007-07-22 8:59 ` Roland McGrath
2007-07-23 2:18 ` David Miller
2007-07-23 6:01 ` Roland McGrath
2007-07-23 6:13 ` Paul Mackerras
2007-07-23 6:27 ` Sam Ravnborg
2007-07-23 7:26 ` Roland McGrath
2007-07-23 8:14 ` Sam Ravnborg
2007-07-23 8:18 ` Roland McGrath
2007-07-23 8:24 ` Sam Ravnborg
2007-07-23 9:25 ` Alan Modra
2007-07-23 11:49 ` Al Viro
2007-07-23 18:00 ` Sam Ravnborg
2007-07-23 18:56 ` Al Viro
2007-07-23 19:13 ` Adrian Bunk
2007-07-23 19:12 ` Roland McGrath
2007-07-23 19:39 ` Al Viro
2007-07-23 20:05 ` Roland McGrath
2007-07-23 20:33 ` Sam Ravnborg
2007-07-23 6:14 ` [PATCH] Move --build-id option Roland McGrath
2007-07-23 6:42 ` Sam Ravnborg
2007-07-23 8:09 ` Roland McGrath
2007-07-23 8:12 ` [PATCH] Use LDFLAGS_MODULE only for .ko links Roland McGrath
2007-07-23 8:16 ` Sam Ravnborg
2007-07-23 6:22 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070723062224.GA3933@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=bunk@stusta.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox