From: Al Viro <viro@ftp.linux.org.uk>
To: Trent Piepho <xyzzy@speakeasy.org>
Cc: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
acpi4asus-u@pimp.vs19.net, Gabriel C <nix.or.die@googlemail.com>,
Richard Purdie <rpurdie@rpsys.net>,
Corentin Chary <corentincj@iksaif.net>
Subject: Re: [1/2] 2.6.23-rc1: known regressions
Date: Mon, 23 Jul 2007 12:25:57 +0100 [thread overview]
Message-ID: <20070723112557.GG21668@ftp.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.58.0707230404290.5535@shell2.speakeasy.net>
On Mon, Jul 23, 2007 at 04:17:05AM -0700, Trent Piepho wrote:
> Here's a trivial patch for this one.
> ------------------------------------------------------------------------
> asus-laptop: Sync with changes to led class
>
> Driver was broken by commit f8a7c6fe14f556ca8eeddce258cb21392d0c3a2f
> leds: Convert from struct class_device to struct device
>
> Convert the LEDs class from struct class_device to struct device
> since class_device is scheduled for removal.
>
> Use (struct led_classdev).dev instead of (struct led_classdev).class_dev
It doesn't fix the real bug in there - if you look carefully at the code,
you'll see that we don't get to these checks if allocation fails halfway
through (and we leak in that case) *and* these checks are not needed at
all if failure happens elsewhere.
next prev parent reply other threads:[~2007-07-23 11:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-23 9:47 [1/2] 2.6.23-rc1: known regressions Michal Piotrowski
2007-07-23 10:21 ` Al Viro
2007-07-23 11:17 ` Trent Piepho
2007-07-23 11:25 ` Al Viro [this message]
2007-07-23 13:12 ` Richard Purdie
2007-07-23 13:36 ` Al Viro
2007-07-23 14:32 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070723112557.GG21668@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=acpi4asus-u@pimp.vs19.net \
--cc=corentincj@iksaif.net \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=nix.or.die@googlemail.com \
--cc=rpurdie@rpsys.net \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox