From: Ingo Molnar <mingo@elte.hu>
To: Daniel Walker <dwalker@mvista.com>
Cc: Rui Nuno Capela <rncbc@rncbc.org>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
RT-Users <linux-rt-users@vger.kernel.org>
Subject: Re: 2.6.22.1-rt4 lockups
Date: Mon, 23 Jul 2007 22:38:58 +0200 [thread overview]
Message-ID: <20070723203858.GA18569@elte.hu> (raw)
In-Reply-To: <1185221746.2573.142.camel@imap.mvista.com>
* Daniel Walker <dwalker@mvista.com> wrote:
> It looks like sched_class->enqueue_task() is NULL and that's why the
> system hangs ..
>
> The reason why that happens is because check_pgt_cache() is called
> from the idle thread, and with PREEMPT_RT check_pgt_cache() locks at
> least one mutex .. Once the idle thread is on a wait_list, as soon as
> it's woke by the mutex owner the system will crash in enqueue_task.
> Since the idle thread has a NULL sched_class->enqueue_task ..
>
> check_pgt_cache() is already getting called from the desched_thread()
> , so I think it could just be removed from i386 cpu_idle().
>
> Anyone have comments on the theory above?
yeah, that call definitely looks wrong in cpu_idle(). Most of the other
check_pgd_cache() calls introduced by commit f1d1a842 look wrong too in
an -rt context. Fix is below.
Ingo
Index: linux-rt.q/arch/i386/kernel/process.c
===================================================================
--- linux-rt.q.orig/arch/i386/kernel/process.c
+++ linux-rt.q/arch/i386/kernel/process.c
@@ -189,7 +189,6 @@ void cpu_idle(void)
tick_nohz_stop_sched_tick();
- check_pgt_cache();
rmb();
idle = pm_idle;
prev parent reply other threads:[~2007-07-23 20:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 11:22 v2.6.22.1-rt3 Thomas Gleixner
2007-07-13 11:36 ` v2.6.22.1-rt3 Remy Bohmer
2007-07-13 16:05 ` v2.6.22.1-rt3 Thomas Gleixner
2007-07-13 16:10 ` v2.6.22.1-rt3 Kevin Hilman
2007-07-13 16:32 ` v2.6.22.1-rt3 Kevin Hilman
2007-07-13 17:18 ` v2.6.22.1-rt3 - Early INT13 boot crash Carsten Emde
2007-07-13 17:25 ` v2.6.22.1-rt3 Fernando Lopez-Lezcano
2007-07-14 0:33 ` v2.6.22.1-rt3 Josh Triplett
2007-07-14 21:39 ` 2.6.22.1-rt3 lockups Rui Nuno Capela
2007-07-20 3:37 ` v2.6.22.1-rt3 Daniel Walker
2007-07-20 3:41 ` v2.6.22.1-rt3 Daniel Walker
2007-07-21 0:25 ` v2.6.22.1-rt3 Thomas Gleixner
2007-07-21 22:07 ` 2.6.22.1-rt4 lockups Rui Nuno Capela
2007-07-22 21:00 ` Rui Nuno Capela
2007-07-23 16:08 ` Daniel Walker
2007-07-23 20:15 ` Daniel Walker
2007-07-23 20:38 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070723203858.GA18569@elte.hu \
--to=mingo@elte.hu \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rncbc@rncbc.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox