From: Matt Mackall <mpm@selenic.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Paul Mundt <lethal@linux-sh.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] mm: Remove slab destructors from kmem_cache_create().
Date: Mon, 23 Jul 2007 16:24:20 -0500 [thread overview]
Message-ID: <20070723212420.GI11115@waste.org> (raw)
In-Reply-To: <20070723140444.159343b2@schroedinger.engr.sgi.com>
On Mon, Jul 23, 2007 at 02:04:44PM -0700, Christoph Lameter wrote:
> Please do not merge this patch. I will reuse the destructor field for
> the kmem_cache_ops in the slab defrag patchset. If you apply this patch
> then I need to readd the parameter later.
The vast majority of slabs won't have any cache ops, right? Wouldn't
it be cleaner to have a kmem_set_cache_ops() for the few that do?
While we're on the subject, has anyone reviewed your defrag stuff?
I read through it a while back and my initial impression is a) it's
awfully complex and invasive and b) it probably won't protect all
workloads.
As this and several other vexing problems stem from the dcache design,
I'd rather abandon the dcache out in the woods so we can replace it
with something less troublesome.
--
Mathematics is the supreme nostalgia of our time.
prev parent reply other threads:[~2007-07-23 21:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-20 1:28 [GIT PULL] mm: Remove slab destructors from kmem_cache_create() Paul Mundt
2007-07-20 1:43 ` Linus Torvalds
2007-07-21 21:28 ` Matt Mackall
2007-07-21 23:42 ` Paul Mundt
2007-07-23 21:04 ` Christoph Lameter
2007-07-23 21:24 ` Matt Mackall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070723212420.GI11115@waste.org \
--to=mpm@selenic.com \
--cc=clameter@sgi.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox