From: Andrew Morton <akpm@linux-foundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Adrian Bunk <bunk@stusta.de>,
Alexey Dobriyan <adobriyan@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: 2.6.23-rc1: BUG_ON in kmap_atomic_prot()
Date: Tue, 24 Jul 2007 11:28:43 -0700 [thread overview]
Message-ID: <20070724112843.0cc104c2.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LFD.0.999.0707241113180.3607@woody.linux-foundation.org>
On Tue, 24 Jul 2007 11:14:21 -0700 (PDT)
Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
>
> On Tue, 24 Jul 2007, Adrian Bunk wrote:
> >
> > buffered_rmqueue() and prep_new_page() are static functions with only
> > one caller each, and for the normal non-debug case it's a really nice
> > optimization to have them inlined automatically.
>
> I'm not at all sure I agree.
>
> Inlining big functions doesn't actually tend to generally generate any
> better code, so if gcc's logic is "single callsite - always inline", then
> that logic is likely not right.
>
fwiw, -fno-inline-functions-called-once (who knew?) takes i386 allnoconfig
vmlinux .text from 928360 up to 955362 bytes (27k larger).
A surprisingly large increase - I wonder if it did something dumb. It
appears to still correctly inline those things which we've manually marked
inline. hm.
It would be nice to defeat the autoinlining for debug purposes though.
next prev parent reply other threads:[~2007-07-24 18:29 UTC|newest]
Thread overview: 227+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-22 21:04 Linus 2.6.23-rc1 Linus Torvalds
2007-07-22 22:10 ` Andre Noll
2007-07-22 22:22 ` Andi Kleen
2007-07-22 23:23 ` Andre Noll
2007-07-22 23:31 ` Andi Kleen
[not found] ` <20070722233840.GJ30660@skl-net.de>
2007-07-22 23:56 ` vdso.so mislinked by buggy linker was " Andi Kleen
2007-07-23 6:03 ` Jakub Jelinek
2007-07-23 8:02 ` Andi Kleen
2007-07-23 12:45 ` Jakub Jelinek
2007-07-23 14:44 ` Andi Kleen
2007-07-23 6:07 ` Jakub Jelinek
2007-07-22 23:33 ` Alistair John Strachan
2007-07-22 23:51 ` Roland McGrath
2007-07-23 0:07 ` Adrian Bunk
2007-07-23 0:31 ` Roland McGrath
2007-07-23 1:43 ` Adrian Bunk
2007-07-23 1:20 ` Gabriel C
2007-07-23 1:23 ` Paul Mundt
2007-07-23 1:27 ` Gabriel C
2007-07-23 1:40 ` Paul Mundt
2007-07-23 4:11 ` Greg KH
[not found] ` <46A40BC7.9030209@googlemail.com>
2007-07-23 2:42 ` Gabriel C
2007-07-23 15:47 ` Bob Picco
2007-07-23 15:54 ` Luck, Tony
2007-07-23 2:48 ` Gabriel C
2007-07-23 7:14 ` alpha, i386,mips,powerpc,ppc,xtensa compile brakage (was Re: Linus 2.6.23-rc1) Jan Dittmer
2007-07-23 7:56 ` Stephen Rothwell
2007-07-23 13:57 ` Josh Boyer
2007-07-23 14:02 ` Gabriel C
2007-07-23 9:50 ` Linus 2.6.23-rc1: ACPI-related oops on x86_64 Mel Gorman
2007-07-23 17:15 ` Len Brown
2007-07-24 10:37 ` Mel Gorman
2007-07-23 15:52 ` Linus 2.6.23-rc1, xen fix Ingo Molnar
2007-07-23 16:43 ` Linus 2.6.23-rc1 Gabriel C
2007-07-23 16:57 ` Ismail Dönmez
2007-07-23 20:44 ` Alessandro Suardi
2007-07-24 14:49 ` Len Brown
2007-07-23 18:38 ` 2.6.23-rc1: BUG_ON in kmap_atomic_prot() Alexey Dobriyan
2007-07-23 19:01 ` Alexey Dobriyan
2007-07-23 20:24 ` Andrew Morton
2007-07-23 20:40 ` Alexey Dobriyan
2007-07-23 21:01 ` Alexey Dobriyan
2007-07-23 21:11 ` Andrew Morton
2007-07-23 21:28 ` Linus Torvalds
2007-07-23 21:37 ` Sam Ravnborg
2007-07-24 17:59 ` Adrian Bunk
2007-07-24 18:14 ` Linus Torvalds
2007-07-24 18:28 ` Andrew Morton [this message]
2007-07-24 19:15 ` Linus Torvalds
2007-07-24 19:40 ` Adrian Bunk
2007-07-24 19:48 ` Linus Torvalds
2007-07-26 18:07 ` Adrian Bunk
2007-07-26 18:19 ` Linus Torvalds
2007-07-24 20:27 ` Andi Kleen
2007-07-24 19:45 ` Linus Torvalds
2007-07-26 6:09 ` commit 7e92b4fc34 - x86, serial: convert legacy COM ports to platform devices - broke my serial console H. Peter Anvin
2007-07-23 22:04 ` 2.6.23-rc1: BUG_ON in kmap_atomic_prot() Alexey Dobriyan
2007-07-23 22:27 ` Andrew Morton
2007-07-24 5:20 ` Alexey Dobriyan
2007-07-24 8:17 ` Jens Axboe
2007-07-24 8:22 ` Jens Axboe
2007-07-24 8:34 ` Andrew Morton
2007-07-24 14:00 ` Dan Williams
2007-07-24 13:55 ` Dan Williams
2007-07-24 10:01 ` Mike Galbraith
2007-07-24 10:37 ` Mike Galbraith
2007-07-24 16:28 ` Andrew Morton
2007-07-24 18:25 ` Linus Torvalds
2007-07-24 20:05 ` Alexey Dobriyan
2007-07-25 17:44 ` Cyrill Gorcunov
2007-07-25 5:09 ` Mike Galbraith
2007-07-27 11:43 ` SD still better than CFS for 3d \b(was Re: 2.6.23-rc1) Kasper Sandberg
2007-07-29 17:06 ` SD still better than CFS for 3d ?(was " Ingo Molnar
[not found] ` <930f95dc0707291154j102494d9m58f4cc452c7ff17c@mail.gmail.com>
2007-07-29 20:47 ` [ck] " Ingo Molnar
[not found] ` <930f95dc0707291431j4e50214di3c01cd44b5597502@mail.gmail.com>
2007-07-30 1:20 ` Matthew Hawkins
2007-07-30 11:46 ` Ingo Molnar
2007-07-30 16:04 ` Miguel Figueiredo
2007-07-30 18:38 ` Ingo Molnar
2007-07-30 21:05 ` Miguel Figueiredo
2007-07-31 16:36 ` Ingo Molnar
2007-07-30 16:19 ` david
2007-07-30 19:01 ` Ingo Molnar
2007-07-30 19:03 ` david
2007-07-30 19:08 ` Ingo Molnar
[not found] ` <op.tv90xghwatcbto@linux.site>
[not found] ` <d3380cee0707300831m33d896aufcbdb188576940a2@mail.gmail.com>
2007-07-30 16:25 ` Matthew Hawkins
2007-07-30 16:50 ` Peter Zijlstra
2007-07-30 17:09 ` Kyle Rose
2007-07-30 16:50 ` Martin Schwidefsky
2007-07-30 16:58 ` Rashkae
2007-07-30 17:51 ` Arjan van de Ven
2007-07-30 18:29 ` Christoph Hellwig
2007-07-30 19:53 ` [ck] Re: SD still better than CFS for 3d ? Roland Dreier
2007-07-30 21:26 ` Christoph Hellwig
2007-07-31 3:07 ` Matthew Hawkins
2007-07-31 7:01 ` Martin Schwidefsky
2007-07-31 12:13 ` Christoph Hellwig
2007-08-01 5:25 ` Adrian Bunk
2007-08-01 6:19 ` Matthew Hawkins
2007-08-01 7:50 ` Adrian Bunk
2007-07-30 17:54 ` [ck] Re: SD still better than CFS for 3d ?(was Re: 2.6.23-rc1) Kenneth Prugh
2007-07-30 19:10 ` Ingo Molnar
2007-07-30 21:24 ` Kenneth Prugh
2007-07-30 21:34 ` Miguel Figueiredo
2007-07-30 22:45 ` Kenneth Prugh
2007-07-31 9:45 ` Ingo Molnar
2007-07-31 13:16 ` Matthew Hawkins
2007-07-31 13:32 ` Miguel Figueiredo
2007-07-31 14:09 ` Ingo Molnar
2007-07-31 15:57 ` Matthew Hawkins
2007-07-31 16:23 ` Miguel Figueiredo
2007-07-31 17:02 ` Matthew Hawkins
2007-07-31 14:18 ` Ingo Molnar
2007-07-31 16:14 ` Matthew Hawkins
2007-07-31 16:45 ` Ingo Molnar
2007-07-30 23:46 ` Kasper Sandberg
2007-07-31 6:31 ` Peter Zijlstra
2007-07-31 8:57 ` Ingo Molnar
2007-07-31 9:11 ` Alan Cox
2007-07-31 9:13 ` Ingo Molnar
2007-07-31 9:19 ` Avi Kivity
2007-07-31 9:44 ` Alan Cox
2007-08-01 23:43 ` Kasper Sandberg
2007-08-02 12:10 ` Ingo Molnar
2007-08-02 15:42 ` Ingo Molnar
2007-08-08 14:38 ` Kasper Sandberg
2007-08-03 6:31 ` Ingo Molnar
2007-08-02 2:35 ` Lee Revell
2007-08-02 11:45 ` Ingo Molnar
2007-08-02 13:39 ` Trond Myklebust
2007-08-02 13:03 ` J. Bruce Fields
[not found] ` <op.twbll7ugatcbto@linux.site>
2007-07-31 8:32 ` [ck] " Ingo Molnar
2007-07-28 2:04 ` Linus 2.6.23-rc1 Kasper Sandberg
2007-07-28 2:35 ` Linus Torvalds
2007-07-28 7:09 ` [ck] " Grzegorz Kulewski
[not found] ` <954c7c800707280045t4607cebfj532ef025a7a57c05@mail.gmail.com>
2007-07-28 17:12 ` Linus Torvalds
2007-07-28 17:33 ` Jan Engelhardt
2007-07-28 18:05 ` Linus Torvalds
2007-07-28 20:51 ` Diego Calleja
2007-07-28 20:59 ` Jan Engelhardt
2007-07-29 5:04 ` Roland Dreier
2007-07-28 21:09 ` Linus Torvalds
2007-07-28 22:16 ` Alex Besogonov
2007-07-29 9:37 ` Martin Steigerwald
2007-07-29 9:04 ` Martin Steigerwald
2007-07-29 10:28 ` Sam Ravnborg
2007-07-29 10:56 ` Martin Steigerwald
2007-07-29 17:42 ` Sam Ravnborg
2007-07-29 18:23 ` Martin Steigerwald
2007-07-29 18:54 ` Satyam Sharma
2007-07-29 19:18 ` Martin Steigerwald
2007-07-31 1:15 ` Carlo Florendo
2007-07-31 9:57 ` Bill Huey
2007-07-31 12:00 ` Mike Galbraith
2007-08-01 2:54 ` Carlo Florendo
2007-07-29 20:24 ` Ingo Molnar
2007-07-29 19:25 ` Sam Ravnborg
2007-07-29 8:42 ` Martin Steigerwald
2007-07-29 9:25 ` Tomas Carnecky
2007-07-28 7:36 ` Matthew Hawkins
2007-07-28 10:40 ` Martin Steigerwald
2007-07-28 16:10 ` Reporting bugs (was Re: [ck] Re: Linus 2.6.23-rc1) Stefan Richter
2007-07-28 16:21 ` Michal Piotrowski
2007-07-28 9:44 ` Linus 2.6.23-rc1 Kasper Sandberg
2007-07-28 17:50 ` Linus Torvalds
2007-07-28 18:07 ` Kasper Sandberg
2007-07-28 19:13 ` Jan Engelhardt
2007-07-28 19:34 ` Linus Torvalds
2007-07-28 21:33 ` Linus Torvalds
2007-07-28 21:55 ` Jan Engelhardt
2007-07-28 22:22 ` Linus Torvalds
2007-08-01 9:21 ` Jan Engelhardt
2007-07-28 10:05 ` [ck] " Martin Steigerwald
2007-07-28 11:06 ` Dirk Schoebel
2007-07-28 13:18 ` Michael Chang
2007-07-28 17:25 ` Linus Torvalds
2007-07-28 18:03 ` jos poortvliet
2007-07-28 18:28 ` Linus Torvalds
2007-07-28 19:28 ` jos poortvliet
2007-07-28 20:07 ` Bill Huey
2007-07-28 21:06 ` Diego Calleja
2007-07-28 21:32 ` Bill Huey
2007-07-28 22:18 ` Linus Torvalds
2007-07-29 1:00 ` Bill Huey
2007-07-29 14:31 ` Diego Calleja
2007-07-29 18:31 ` Martin Steigerwald
2007-07-29 20:25 ` Mike Galbraith
2007-07-29 21:48 ` Bill Huey
2007-07-30 5:03 ` Mike Galbraith
2007-08-07 6:55 ` Daniel Phillips
2007-08-07 15:33 ` Alan Cox
2007-07-28 20:31 ` Linus Torvalds
2007-07-29 0:03 ` Con Kolivas
2007-07-29 1:23 ` Charles philip Chan
2007-08-01 4:17 ` Roman Zippel
2007-08-01 5:46 ` Carlo Florendo
2007-08-01 6:16 ` Hua Zhong
2007-08-01 7:05 ` [ck] Re: Linus 2.6.23-rc1 -- It does not matter who's code gets merged! Arjan van de Ven
2007-08-01 7:12 ` Carlo Florendo
2007-08-01 8:14 ` jos
2007-08-01 14:02 ` Arjan van de Ven
2007-08-01 18:40 ` Hua Zhong
2007-08-01 22:04 ` Arjan van de Ven
2007-08-02 15:22 ` Andrea Arcangeli
2007-08-02 20:03 ` Frank Ch. Eigler
2007-08-02 20:05 ` Arjan van de Ven
2007-08-02 20:33 ` Frank Ch. Eigler
2007-08-04 8:04 ` [ck] Re: Linus 2.6.23-rc1 -- It does not matter whose " Daniel Phillips
2007-08-01 7:09 ` [ck] Re: Linus 2.6.23-rc1 Carlo Florendo
2007-08-01 12:31 ` Alan Cox
2007-07-28 21:07 ` Jory A. Pratt
2007-07-29 15:04 ` Ingo Molnar
2007-07-29 23:04 ` George Sescher
2007-07-29 23:18 ` Linus Torvalds
2007-07-29 23:38 ` George Sescher
2007-07-29 23:58 ` Linus Torvalds
2007-07-30 5:12 ` [ck] " Matthew Hawkins
2007-07-31 10:05 ` Bill Huey
2007-07-31 14:04 ` Ingo Molnar
2007-07-31 15:44 ` Linus Torvalds
2007-07-30 6:44 ` Ingo Molnar
2007-07-30 7:06 ` George Sescher
2007-07-30 7:55 ` Ingo Molnar
2007-07-30 9:26 ` George Sescher
2007-07-30 10:26 ` Ingo Molnar
2007-07-30 16:13 ` Kasper Sandberg
2007-07-28 14:52 ` Ronni Nielsen
2007-07-28 17:30 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070724112843.0cc104c2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox