From: Andrew Morton <akpm@linux-foundation.org>
To: Robin Getz <rgetz@blackfin.uclinux.org>
Cc: "Mike Frysinger" <vapier.adi@gmail.com>,
linux-kernel@vger.kernel.org, "Greg Ungerer" <gerg@snapgear.com>,
"Russell King" <rmk@arm.linux.org.uk>,
"Paul Mundt" <lethal@linux-sh.org>,
"Tim Bird" <tim.bird@am.sony.com>,
bryan.wu@analog.com
Subject: Re: early_printk accessing __log_buf
Date: Tue, 24 Jul 2007 14:30:04 -0700 [thread overview]
Message-ID: <20070724143004.6325a511.akpm@linux-foundation.org> (raw)
In-Reply-To: <200707241612.56509.rgetz@blackfin.uclinux.org>
On Tue, 24 Jul 2007 16:12:56 -0400
Robin Getz <rgetz@blackfin.uclinux.org> wrote:
> On Tue 24 Jul 2007 14:12, Andrew Morton pondered:
> > Oh well, it sounds like we need the super-duper fast version. Keep it
> > as simple as possible, please.
>
> What about:
>
> int log_buf_copy(void *dest, int idx, size_t n);
>
> starting at index idx - copy n bytes to dest, return the number of bytes
> copied (in case there are not n bytes in the log_buf yet).
Sounds sensible. I'd make it return size_t and take a char* arg though.
Or just use `int' - size_t is a bit of a pain and this is all kernel-internal
anwyay.
next prev parent reply other threads:[~2007-07-24 21:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 21:56 early_printk accessing __log_buf Robin Getz
2007-07-18 22:16 ` Andrew Morton
2007-07-18 23:39 ` Robin Getz
2007-07-18 23:53 ` Mike Frysinger
2007-07-19 3:37 ` Robin Getz
2007-07-19 3:47 ` Andrew Morton
2007-07-19 0:26 ` Andrew Morton
2007-07-19 2:26 ` Stephane Couture
2007-07-19 3:58 ` Robin Getz
2007-07-22 23:50 ` Mike Frysinger
2007-07-23 0:14 ` Paul Mundt
2007-07-23 18:19 ` Robin Getz
2007-07-23 20:15 ` Andrew Morton
2007-07-23 20:54 ` Mike Frysinger
2007-07-23 21:05 ` Andrew Morton
2007-07-23 22:10 ` Mike Frysinger
2007-07-23 22:15 ` Robin Getz
2007-07-23 22:34 ` Andrew Morton
2007-07-24 17:50 ` Robin Getz
2007-07-24 18:12 ` Andrew Morton
2007-07-24 20:12 ` Robin Getz
2007-07-24 21:30 ` Andrew Morton [this message]
2007-07-31 7:47 ` Mike Frysinger
2007-07-31 7:59 ` Bryan Wu
2007-07-31 8:11 ` Mike Frysinger
2007-07-31 18:36 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070724143004.6325a511.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bryan.wu@analog.com \
--cc=gerg@snapgear.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rgetz@blackfin.uclinux.org \
--cc=rmk@arm.linux.org.uk \
--cc=tim.bird@am.sony.com \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox