Re: 2.6.23rc1 git: EIP is at acpi_processor_throttling_seq_show+0x8b/0xdd [processor]

[Arkadiusz Miskiewicz <arekm@maven.pl>]

On Monday 23 of July 2007, Len Brown wrote:
> On Monday 23 July 2007 11:40, Arkadiusz Miskiewicz wrote:
> > After booting fresh 2.6.23rc1 taken from git I noticed oops in dmesg:
> >
> > [   46.274038] BUG: unable to handle kernel NULL pointer dereference at
> > virtual address 00000000 [   46.274042]  printing eip:
> > [   46.274044] f8b5b2dc
> > [   46.274045] *pde = 00000000
> > [   46.274048] Oops: 0000 [#1]
[...]
>
> Please try the patch below -- seems that I somehow neglected to include it
> in my rc1 batch.

No oops with patch applied. Thanks!

>
> thanks,
> -Len
>
> Subject: fix oops due to typo in new throttling code
> From: Luming Yu <luming.yu@gmail.com>
>
>
> Signed-off-by: Luming Yu <luming.yu@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Len Brown <len.brown@intel.com>
>
> ---
>
>  drivers/acpi/processor_throttling.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> Index: linus/drivers/acpi/processor_throttling.c
> ===================================================================
> --- linus.orig/drivers/acpi/processor_throttling.c
> +++ linus/drivers/acpi/processor_throttling.c
> @@ -658,18 +658,20 @@ static int acpi_processor_throttling_seq
>  		   pr->throttling.state_count - 1);
>
>  	seq_puts(seq, "states:\n");
> -	if (acpi_processor_get_throttling == acpi_processor_get_throttling_fadt)
> +	if (pr->throttling.acpi_processor_get_throttling ==
> +			acpi_processor_get_throttling_fadt) {
>  		for (i = 0; i < pr->throttling.state_count; i++)
>  			seq_printf(seq, "   %cT%d:                  %02d%%\n",
>  				   (i == pr->throttling.state ? '*' : ' '), i,
>  				   (pr->throttling.states[i].performance ? pr->
>  				    throttling.states[i].performance / 10 : 0));
> -	else
> +	} else {
>  		for (i = 0; i < pr->throttling.state_count; i++)
>  			seq_printf(seq, "   %cT%d:                  %02d%%\n",
>  				   (i == pr->throttling.state ? '*' : ' '), i,
>  				   (int)pr->throttling.states_tss[i].
>  				   freqpercentage);
> +	}
>
>        end:
>  	return 0;



-- 
Arkadiusz Miśkiewicz        PLD/Linux Team
arekm / maven.pl            http://ftp.pld-linux.org/