From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764097AbXGXTtr (ORCPT ); Tue, 24 Jul 2007 15:49:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756370AbXGXTtg (ORCPT ); Tue, 24 Jul 2007 15:49:36 -0400 Received: from mailout.stusta.mhn.de ([141.84.69.5]:43343 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754172AbXGXTtf (ORCPT ); Tue, 24 Jul 2007 15:49:35 -0400 Date: Tue, 24 Jul 2007 21:49:01 +0200 From: Adrian Bunk To: Andy Whitcroft Cc: Jan Engelhardt , Paul Mundt , Andrew Morton , "Kok, Auke" , Randy Dunlap , Joel Schopp , linux-kernel@vger.kernel.org Subject: Re: [PATCH] update checkpatch.pl to version 0.08 Message-ID: <20070724194901.GE6019@stusta.de> References: <740c90243aaa6f6d4640d71230c4fa27@pinky> <46A534EA.6030008@intel.com> <46A5C12B.3080904@shadowen.org> <20070724021526.3d92286b.akpm@linux-foundation.org> <20070724172217.GA10725@linux-sh.org> <46A64587.2010704@shadowen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <46A64587.2010704@shadowen.org> User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 24, 2007 at 07:31:35PM +0100, Andy Whitcroft wrote: > Jan Engelhardt wrote: > > On Jul 25 2007 02:22, Paul Mundt wrote: > >> Perhaps CodingStyle can start being versioned, so people can opt out of > >> certain 'improvements' whenever someone has a vision, much like some > >> nameless licenses. > > > > I'd say Codingstyle is versioned by means of git commit IDs. > > > >> Personally I prefer the second style, and if there's a comment block, > >> then it makes sense to complete the tree with {}'s (the keyword here is > >> prefer, as it's a personal preference). checkpatch has been quite useful > >> for catching obviously broken things, and now it seems like it's just > >> overreaching. Perhaps this functionality can be split in to a lite > >> checkpatch for catching show-stoppers for application and then something > >> more akin to a CodingStyle validator for the folks interested in > >> arbitrarily defining convention, which they can use freely while the rest > >> of us try to get something useful done. > > > > /me thinks of ... checkpath --check-me-harder > > Yep I think the consensus is we need a > "--i-don't-agree-just-check-things-which-will-get-me-rejected-out-of-hand" > option of some sort which will restrict output to the real errors. No, the default should be to show only the real errors. > -apw cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed