* [PATCH] bsg: Fix build for CONFIG_BLOCK=n
@ 2007-07-25 7:23 Paul Mundt
2007-07-25 7:26 ` Jens Axboe
2007-07-25 11:04 ` Bartlomiej Zolnierkiewicz
0 siblings, 2 replies; 4+ messages in thread
From: Paul Mundt @ 2007-07-25 7:23 UTC (permalink / raw)
To: FUJITA Tomonori; +Cc: Jens Axboe, Andrew Morton, linux-kernel
BLK_DEV_BSG was added outside of the if BLOCK check, which allows it to
be enabled when CONFIG_BLOCK=n. This leads to many screenlengths of
errors, starting with a parse error on the request_queue_t definition.
Obviously this wasn't intended for CONFIG_BLOCK=n usage, so just move the
option back in to the block.
Caught with a randconfig on sh.
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
--
block/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/Kconfig b/block/Kconfig
index ca2ef4e..2484e0e 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -49,8 +49,6 @@ config LSF
If unsure, say Y.
-endif # BLOCK
-
config BLK_DEV_BSG
bool "Block layer SG support v4 (EXPERIMENTAL)"
depends on EXPERIMENTAL
@@ -64,4 +62,6 @@ config BLK_DEV_BSG
protocols (e.g. Task Management Functions and SMP in Serial
Attached SCSI).
+endif # BLOCK
+
source block/Kconfig.iosched
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] bsg: Fix build for CONFIG_BLOCK=n
2007-07-25 7:23 [PATCH] bsg: Fix build for CONFIG_BLOCK=n Paul Mundt
@ 2007-07-25 7:26 ` Jens Axboe
2007-07-25 11:04 ` Bartlomiej Zolnierkiewicz
1 sibling, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2007-07-25 7:26 UTC (permalink / raw)
To: Paul Mundt, FUJITA Tomonori, Andrew Morton, linux-kernel
On Wed, Jul 25 2007, Paul Mundt wrote:
> BLK_DEV_BSG was added outside of the if BLOCK check, which allows it to
> be enabled when CONFIG_BLOCK=n. This leads to many screenlengths of
> errors, starting with a parse error on the request_queue_t definition.
> Obviously this wasn't intended for CONFIG_BLOCK=n usage, so just move the
> option back in to the block.
>
> Caught with a randconfig on sh.
>
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
That's definitely correct.
Acked-by: Jens Axboe <jens.axboe@oracle.com>
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bsg: Fix build for CONFIG_BLOCK=n
2007-07-25 7:23 [PATCH] bsg: Fix build for CONFIG_BLOCK=n Paul Mundt
2007-07-25 7:26 ` Jens Axboe
@ 2007-07-25 11:04 ` Bartlomiej Zolnierkiewicz
2007-07-26 10:51 ` FUJITA Tomonori
1 sibling, 1 reply; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2007-07-25 11:04 UTC (permalink / raw)
To: Paul Mundt; +Cc: FUJITA Tomonori, Jens Axboe, Andrew Morton, linux-kernel
Hi,
On Wednesday 25 July 2007, Paul Mundt wrote:
> BLK_DEV_BSG was added outside of the if BLOCK check, which allows it to
> be enabled when CONFIG_BLOCK=n. This leads to many screenlengths of
> errors, starting with a parse error on the request_queue_t definition.
> Obviously this wasn't intended for CONFIG_BLOCK=n usage, so just move the
> option back in to the block.
>
> Caught with a randconfig on sh.
also pointed out in my bsg review from a week ago ;)
http://lkml.org/lkml/2007/7/17/487
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>
Thanks for fixing this up.
Bart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bsg: Fix build for CONFIG_BLOCK=n
2007-07-25 11:04 ` Bartlomiej Zolnierkiewicz
@ 2007-07-26 10:51 ` FUJITA Tomonori
0 siblings, 0 replies; 4+ messages in thread
From: FUJITA Tomonori @ 2007-07-26 10:51 UTC (permalink / raw)
To: bzolnier; +Cc: lethal, fujita.tomonori, jens.axboe, akpm, linux-kernel
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: [PATCH] bsg: Fix build for CONFIG_BLOCK=n
Date: Wed, 25 Jul 2007 13:04:56 +0200
>
> Hi,
>
> On Wednesday 25 July 2007, Paul Mundt wrote:
> > BLK_DEV_BSG was added outside of the if BLOCK check, which allows it to
> > be enabled when CONFIG_BLOCK=n. This leads to many screenlengths of
> > errors, starting with a parse error on the request_queue_t definition.
> > Obviously this wasn't intended for CONFIG_BLOCK=n usage, so just move the
> > option back in to the block.
> >
> > Caught with a randconfig on sh.
>
> also pointed out in my bsg review from a week ago ;)
>
> http://lkml.org/lkml/2007/7/17/487
Oops, sorry.
> > Signed-off-by: Paul Mundt <lethal@linux-sh.org>
>
> Thanks for fixing this up.
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-07-26 10:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-25 7:23 [PATCH] bsg: Fix build for CONFIG_BLOCK=n Paul Mundt
2007-07-25 7:26 ` Jens Axboe
2007-07-25 11:04 ` Bartlomiej Zolnierkiewicz
2007-07-26 10:51 ` FUJITA Tomonori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox