From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933976AbXGYQzd (ORCPT ); Wed, 25 Jul 2007 12:55:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763970AbXGYQzU (ORCPT ); Wed, 25 Jul 2007 12:55:20 -0400 Received: from hera.kernel.org ([140.211.167.34]:59436 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752061AbXGYQzR convert rfc822-to-8bit (ORCPT ); Wed, 25 Jul 2007 12:55:17 -0400 From: Len Brown Organization: Intel Open Source Technology Center To: Noah Watkins Subject: Re: 2.6.23-rc1 -- build failure Date: Wed, 25 Jul 2007 12:55:12 -0400 User-Agent: KMail/1.9.5 Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org References: <20070725161116.GF23458@ittc.ku.edu> In-Reply-To: <20070725161116.GF23458@ittc.ku.edu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <200707251255.12359.lenb@kernel.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 25 July 2007 12:11, Noah Watkins wrote: > Latest git tree gives following build errors (config attached): > > make -C /yggnfs/nwatkins/kernels/git-linux-2.6/linux-2.6 O=/yggnfs/nwatkins/kernels/git-linux-2.6/build > Using /yggnfs/nwatkins/kernels/git-linux-2.6/linux-2.6 as source for kernel > GEN /yggnfs/nwatkins/kernels/git-linux-2.6/build/Makefile > CHK include/linux/version.h > CHK include/linux/utsrelease.h > CALL /yggnfs/nwatkins/kernels/git-linux-2.6/linux-2.6/scripts/checksyscalls.sh > CHK include/linux/compile.h > CC arch/i386/kernel/acpi/cstate.o > In file included from /yggnfs/nwatkins/kernels/git-linux-2.6/linux-2.6/arch/i386/kernel/acpi/cstate.c:16: > /yggnfs/nwatkins/kernels/git-linux-2.6/linux-2.6/include/acpi/processor.h:90: error: expected specifier-qualifier-list before ‘acpi_integer’ > /yggnfs/nwatkins/kernels/git-linux-2.6/linux-2.6/include/acpi/processor.h:108: error: expected specifier-qualifier-list before ‘acpi_integer’ > /yggnfs/nwatkins/kernels/git-linux-2.6/linux-2.6/include/acpi/processor.h:131: error: expected specifier-qualifier-list before ‘acpi_integer’ > /yggnfs/nwatkins/kernels/git-linux-2.6/linux-2.6/include/acpi/processor.h:149: error: expected specifier-qualifier-list before ‘acpi_integer’ > /yggnfs/nwatkins/kernels/git-linux-2.6/linux-2.6/include/acpi/processor.h:205: error: expected specifier-qualifier-list before ‘acpi_handle’ > /yggnfs/nwatkins/kernels/git-linux-2.6/linux-2.6/include/acpi/processor.h:319: warning: ‘struct acpi_device’ declared inside parameter list > /yggnfs/nwatkins/kernels/git-linux-2.6/linux-2.6/include/acpi/processor.h:319: warning: its scope is only this definition or declaration, which is probably not what you want > /yggnfs/nwatkins/kernels/git-linux-2.6/linux-2.6/include/acpi/processor.h:322: warning: ‘struct acpi_device’ declared inside parameter list > make[4]: *** [arch/i386/kernel/acpi/cstate.o] Error 1 > make[3]: *** [arch/i386/kernel/acpi] Error 2 > make[2]: *** [arch/i386/kernel] Error 2 > make[1]: *** [_all] Error 2 > make: *** [all] Error 2 try this: >>From akpm@linux-foundation.org Mon Jul 23 20:50:44 2007 ----------------------------------------------------- Subject: X86_POWERNOW_K8_ACPI must depend on ACPI From: Adrian Bunk This patch fixes the following compile error introduced by commit e8666b2718fdb5bf0ea7c3126f7e292bbbf2946b and reported by Alexey Dobriyan: <-- snip --> CC arch/i386/kernel/acpi/cstate.o In file included from arch/i386/kernel/acpi/cstate.c:17: include/acpi/processor.h:88: error: expected specifier-qualifier-list before 'acpi_integer' <-- snip --> If you select something you must ensure that the dependencies of what you are selecting are fulfilled. Signed-off-by: Adrian Bunk Cc: Alexey Dobriyan Cc: Joshua Hoblitt Cc: Dave Jones Cc: Michal Piotrowski Cc: Len Brown Cc: Andrew Morton Signed-off-by: Andrew Morton --- arch/i386/kernel/cpu/cpufreq/Kconfig | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN arch/i386/kernel/cpu/cpufreq/Kconfig~x86_powernow_k8_acpi-must-depend-on-acpi arch/i386/kernel/cpu/cpufreq/Kconfig --- a/arch/i386/kernel/cpu/cpufreq/Kconfig~x86_powernow_k8_acpi-must-depend-on-acpi +++ a/arch/i386/kernel/cpu/cpufreq/Kconfig @@ -92,7 +92,7 @@ config X86_POWERNOW_K8 config X86_POWERNOW_K8_ACPI bool "ACPI Support" select ACPI_PROCESSOR - depends on X86_POWERNOW_K8 + depends on ACPI && X86_POWERNOW_K8 default y help This provides access to the K8s Processor Performance States via ACPI. _