[PATCH] bsg: Fix build for CONFIG_BLOCK=n

[PATCH] bsg: Fix build for CONFIG_BLOCK=n

[Paul Mundt]

BLK_DEV_BSG was added outside of the if BLOCK check, which allows it to
be enabled when CONFIG_BLOCK=n. This leads to many screenlengths of
errors, starting with a parse error on the request_queue_t definition.
Obviously this wasn't intended for CONFIG_BLOCK=n usage, so just move the
option back in to the block.

Caught with a randconfig on sh.

Signed-off-by: Paul Mundt <lethal@linux-sh.org>

--

 block/Kconfig |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/Kconfig b/block/Kconfig
index ca2ef4e..2484e0e 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -49,8 +49,6 @@ config LSF
 
 	  If unsure, say Y.
 
-endif # BLOCK
-
 config BLK_DEV_BSG
 	bool "Block layer SG support v4 (EXPERIMENTAL)"
 	depends on EXPERIMENTAL
@@ -64,4 +62,6 @@ config BLK_DEV_BSG
 	protocols (e.g. Task Management Functions and SMP in Serial
 	Attached SCSI).
 
+endif # BLOCK
+
 source block/Kconfig.iosched

Re: [PATCH] bsg: Fix build for CONFIG_BLOCK=n

[Jens Axboe]

On Wed, Jul 25 2007, Paul Mundt wrote:
> BLK_DEV_BSG was added outside of the if BLOCK check, which allows it to
> be enabled when CONFIG_BLOCK=n. This leads to many screenlengths of
> errors, starting with a parse error on the request_queue_t definition.
> Obviously this wasn't intended for CONFIG_BLOCK=n usage, so just move the
> option back in to the block.
> 
> Caught with a randconfig on sh.
> 
> Signed-off-by: Paul Mundt <lethal@linux-sh.org>

That's definitely correct.

Acked-by: Jens Axboe <jens.axboe@oracle.com>

-- 
Jens Axboe

Re: [PATCH] bsg: Fix build for CONFIG_BLOCK=n

[Bartlomiej Zolnierkiewicz]

Hi,

On Wednesday 25 July 2007, Paul Mundt wrote:
> BLK_DEV_BSG was added outside of the if BLOCK check, which allows it to
> be enabled when CONFIG_BLOCK=n. This leads to many screenlengths of
> errors, starting with a parse error on the request_queue_t definition.
> Obviously this wasn't intended for CONFIG_BLOCK=n usage, so just move the
> option back in to the block.
> 
> Caught with a randconfig on sh.

also pointed out in my bsg review from a week ago ;)

http://lkml.org/lkml/2007/7/17/487

> Signed-off-by: Paul Mundt <lethal@linux-sh.org>

Thanks for fixing this up.

Bart

Re: [PATCH] bsg: Fix build for CONFIG_BLOCK=n

[FUJITA Tomonori]

From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: [PATCH] bsg: Fix build for CONFIG_BLOCK=n
Date: Wed, 25 Jul 2007 13:04:56 +0200

> 
> Hi,
> 
> On Wednesday 25 July 2007, Paul Mundt wrote:
> > BLK_DEV_BSG was added outside of the if BLOCK check, which allows it to
> > be enabled when CONFIG_BLOCK=n. This leads to many screenlengths of
> > errors, starting with a parse error on the request_queue_t definition.
> > Obviously this wasn't intended for CONFIG_BLOCK=n usage, so just move the
> > option back in to the block.
> > 
> > Caught with a randconfig on sh.
> 
> also pointed out in my bsg review from a week ago ;)
> 
> http://lkml.org/lkml/2007/7/17/487

Oops, sorry.


> > Signed-off-by: Paul Mundt <lethal@linux-sh.org>
> 
> Thanks for fixing this up.

Thanks!