From: Christoph Hellwig <hch@infradead.org>
To: Greg Ungerer <gerg@snapgear.com>
Cc: Christoph Hellwig <hch@infradead.org>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [M68KNOMMU]: create hw_irq.h
Date: Wed, 25 Jul 2007 14:17:38 +0100 [thread overview]
Message-ID: <20070725131738.GA7043@infradead.org> (raw)
In-Reply-To: <46A74415.7000408@snapgear.com>
On Wed, Jul 25, 2007 at 10:37:41PM +1000, Greg Ungerer wrote:
> Christoph Hellwig wrote:
> >On Wed, Jul 25, 2007 at 10:07:20PM +1000, Greg Ungerer wrote:
> >>Need an include/asm-m68knommu/hw_irq.h for kernel/hrtimer.c
> >
> >hrtimer.c should be fixed not to include it instead.
>
> Indirectly it is coming from include/linux/irq.h
> (which means that compilation of a few kernel/irq/*.c files
> fail on m68knommu without hw_irq.h existing too)
sorry. m68knommu uses genirq now and it'll have to provide hw_irq.h.
Generic code just shouldn't include it direclty.
Objection to the patch taken back.
(And yes, long-term we need to fix up the mess of irq-related headers,
and Al announced he's gonna start that once 2.6.23 is out)
prev parent reply other threads:[~2007-07-25 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 12:07 [M68KNOMMU]: create hw_irq.h Greg Ungerer
2007-07-25 12:17 ` Christoph Hellwig
2007-07-25 12:37 ` Greg Ungerer
2007-07-25 13:17 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070725131738.GA7043@infradead.org \
--to=hch@infradead.org \
--cc=gerg@snapgear.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox