From: Evgeniy Dushistov <dushistov@mail.ru>
To: Mark Fortescue <mark@mtfhpc.demon.co.uk>
Cc: wli@holomorphy.com, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add in SunOS 4.1.x compatible mode for UFS
Date: Wed, 25 Jul 2007 23:14:37 +0400 [thread overview]
Message-ID: <20070725191437.GA29943@rain> (raw)
In-Reply-To: <Pine.LNX.4.61.0707251718380.20510@mtfhpc.demon.co.uk>
Looks good.
Just a few minor things:
On Wed, Jul 25, 2007 at 06:27:46PM +0100, Mark Fortescue wrote:
> Macros have been put in to alow suport for the old static table Cylinder
> Groups
> but this implementation does not use them yet.
But why add them to patch?
> + /* Sort out mod used on SunOS 4.1.3 for fs_state */
> + uspi->s_postblformat = fs32_to_cpu(sb, usb3->fs_postblformat);
> + if (((flags & UFS_ST_MASK) == UFS_ST_SUNOS) &&
> + (uspi->s_postblformat != UFS_42POSTBLFMT))
> + {
> + flags &= ~UFS_ST_MASK;
> + flags |= UFS_ST_SUN;
> + }
> +
>
Documentation/CodingStyle: if () {
> switch (UFS_SB(sb)->s_flags & UFS_ST_MASK) {
> + case UFS_ST_SUNOS:
> + if (fs32_to_cpu(sb, usb3->fs_postblformat == UFS_42POSTBLFMT))
Really should be so?
May be you mean:
fs32_to_cpu(sb, usb3->fs_postblformat) == UFS_42POSTBLFMT ?
^
--
/Evgeniy
next prev parent reply other threads:[~2007-07-25 19:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-25 17:27 [PATCH] Add in SunOS 4.1.x compatible mode for UFS Mark Fortescue
2007-07-25 19:14 ` Evgeniy Dushistov [this message]
2007-07-25 21:01 ` Mark Fortescue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070725191437.GA29943@rain \
--to=dushistov@mail.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@mtfhpc.demon.co.uk \
--cc=sparclinux@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox