Re: 2.6.23-rc1-mm1

Len Brown
2007-07-25T17:23:57Z

On Wednesday 25 July 2007 08:25, Cedric Le Goater wrote:
> Hello,
>
> Andrew Morton wrote:
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc1/2.6.23-rc1-mm1/
>
> I'm having issue compiling on i386 and x86_64.
>
> make defconfig on i386 :
>
> LD init/built-in.o
> LD .tmp_vmlinux1
> drivers/built-in.o(.text+0x9649): In function `acpi_pci_choose_state':
> : undefined reference to `acpi_pm_device_sleep_state'
> drivers/built-in.o(.text+0x3b2f5): In function `pnpacpi_suspend':
> : undefined reference to `acpi_pm_device_sleep_state'
>
> probably this commit fd4aff1a28eecbd729b409bf7d3eff5948f20414 in the acpi tree.

Looks like mm's git-acpi.patch is missing a few things that are in the latest acpi tree.
Apparently I exposed this issue to Andrew before I exposed the fix, and he got the
former, but not the later -- my fault.

The root problem is that CONFIG_ACPI_SLEEP is not set in defconfig,
and it is not set because CONFIG_SMP=y, but CONFIG_HOTPLUG_CPU=n

So tweaking that will get i386 and x86_64 building. However, it will not fix ia64.
For that, the changes in the latest acpi tree are necessary.

Andrew, you want to re-pull the acpi tree, or do you want me to send
you some patches on top of the current mm?

-Len