Re: [-mm patch] one e1000 driver should be enough for everyone

Kok, Auke
2007-07-25T15:21:28Z

Jeff Garzik wrote:
> Adrian Bunk wrote:
>> I found the discussion, and Christoph's e1000e sounds like the best name
>> ("new" doesn't say whether it's a new driver for old hardware or a
>> driver for new hardware).
>
> Yeah, I think "e1000new" is a lame name.

Moreover, Andrew should probably just drop this driver from -mm for now.

> e1000e is good, or even e1001e if we wanted even more symmetry :)

I'm working on "e1000e" right now...

>> No problem for me, but this obviously implies that global code in the
>> new driver has to be renamed.
>
> Yes. A global namespace is a global namespace.

yes, these are some of the kinks I still need to address. Allthough minor, it's
going to take me some time to get it to the first step before I want to submit
it (patience :))

>> And please ensure that they will always support distinct PCI IDs, or
>> there will be the following common pattern if both drivers support
>> a card:
>
> IIRC I think Auke said there is some minor PCI ID overlap that must be
> addressed in the transition. Disappointing and it raises transition
> issues, but that's the way the split falls out naturally AFAICS.

I'll submit it with only ich9 id's at first, but it will be able to drive (sysfs
bind) to some other devices too. This allows me to keep an eye out on the future
structure that I want to give it without removing too much code that I might
then later have to add back.

Auke