Re: [PATCH 3/4] include asm-mips add missing edac h file

Andrew Morton
2007-07-26T05:25:29Z

On Wed, 25 Jul 2007 14:55:01 -0600 dougthompson@xmission.com wrote:

> --- /dev/null
> +++ linux-2.6.23-rc1/include/asm-mips/edac.h
> @@ -0,0 +1,35 @@
> +#ifndef ASM_EDAC_H
> +#define ASM_EDAC_H
> +
> +/* ECC atomic, DMA, SMP and interrupt safe scrub function */
> +
> +static __inline__ void atomic_scrub(void *va, u32 size)

Please don't use __inline__ or __inline. Good old "inline" will do.

<cc's the checkpatch maintainer>

<edits the diff>

> +{
> + unsigned long *virt_addr = va;
> + unsigned long temp;
> + u32 i;
> +
> + for (i = 0; i < size / sizeof(unsigned long); i++, virt_addr++) {
> +
> + /*
> + * Very carefully read and write to memory atomically
> + * so we are interrupt, DMA and SMP safe.
> + *
> + * Intel: asm("lock; addl $0, %0"::"m"(*virt_addr));
> + */
> +
> + __asm__ __volatile__ (
> + " .set mips3 \n"
> + "1: ll %0, %1 # atomic_add \n"
> + " ll %0, %1 # atomic_add \n"
> + " addu %0, $0 \n"
> + " sc %0, %1 \n"
> + " beqz %0, 1b \n"
> + " .set mips0 \n"
> + : "=&r" (temp), "=m" (*virt_addr)
> + : "m" (*virt_addr));
> +
> + }
> +}

hm, I'd have thought that we could us plain old atomic_add() for this.