From: Andrew Morton <akpm@linux-foundation.org>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: linux-kernel@vger.kernel.org, wwoods@redhat.com
Subject: Re: [PATCH] core_pattern: Add ability for core_pattern to parse arguments when pattern is a pipe
Date: Thu, 26 Jul 2007 11:48:32 -0700 [thread overview]
Message-ID: <20070726114832.faf14bb0.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070726173923.GA5701@hmsreliant.homelinux.net>
On Thu, 26 Jul 2007 13:40:19 -0400 Neil Horman <nhorman@tuxdriver.com> wrote:
> Currently, core dumps can be redirected to a pipe by placing the
> following string template in /proc/sys/kernel/core_pattern:
> |<path/to/application>
> This patch extends this ability, allowing the core_pattern to contain arguments
> to be passed as an argv array to the userspace helper application. It also add
> a format specifier, %c, which allows the RLIM_CORE value of the crashing
> application to be passed on the command line, since RLIMIT_CORE is reduced to
> zero when execing the userspace helper
This all seems to be getting a bit nutty. Who needs this feature
and what will they do with it, etc?
You have a few open-coded kstrdup()s in there, btw. And an open-coded
free_argv_array() on the error path. And a lot of checkpatch warnings.
next prev parent reply other threads:[~2007-07-26 18:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 17:40 [PATCH] core_pattern: Add ability for core_pattern to parse arguments when pattern is a pipe Neil Horman
2007-07-26 18:48 ` Andrew Morton [this message]
2007-07-26 19:31 ` Neil Horman
2007-07-26 19:47 ` Andrew Morton
2007-07-26 20:20 ` Neil Horman
2007-07-26 20:35 ` Andrew Morton
2007-07-26 21:46 ` Neil Horman
2007-07-26 19:36 ` Will Woods
2007-07-26 19:52 ` Andrew Morton
2007-07-26 22:02 ` Jeremy Fitzhardinge
2007-07-27 10:32 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070726114832.faf14bb0.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=wwoods@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox