* [PATCH] MAINTAINERS: use relevant mailing lists
@ 2007-07-27 0:08 Randy Dunlap
2007-07-27 0:17 ` Jesper Juhl
2007-07-27 0:31 ` Andrew Morton
0 siblings, 2 replies; 5+ messages in thread
From: Randy Dunlap @ 2007-07-27 0:08 UTC (permalink / raw)
To: lkml; +Cc: akpm
From: Randy Dunlap <randy.dunlap@oracle.com>
Add text on using relevant mailing lists.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
MAINTAINERS | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
--- linux-2623-rc1g2.orig/MAINTAINERS
+++ linux-2623-rc1g2/MAINTAINERS
@@ -23,15 +23,18 @@ trivial patch so apply some common sense
4. When you are happy with a change make it generally available for
testing and await feedback.
-5. Make a patch available to the relevant maintainer in the list. Use
- 'diff -u' to make the patch easy to merge. Be prepared to get your
- changes sent back with seemingly silly requests about formatting
- and variable names. These aren't as silly as they seem. One
- job the maintainers (and especially Linus) do is to keep things
+5. Make a patch available to the relevant maintainer(s) and mailing
+ list(s). Use 'diff -u' to make the patch easy to merge. Be prepared
+ to get your changes sent back with seemingly silly requests about
+ formatting and variable names. These aren't as silly as they seem.
+ One job the maintainers (and especially Linus) do is to keep things
looking the same. Sometimes this means that the clever hack in
your driver to get around a problem actually needs to become a
generalized kernel feature ready for next time.
+ Use the relevant mailing list(s) -- don't just send everything to
+ lkml (linux-kernel@vger.kernel.org).
+
PLEASE check your patch with the automated style checker
(scripts/checkpatch.pl) to catch trival style violations.
See Documentation/CodingStyle for guidance here.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MAINTAINERS: use relevant mailing lists
2007-07-27 0:08 [PATCH] MAINTAINERS: use relevant mailing lists Randy Dunlap
@ 2007-07-27 0:17 ` Jesper Juhl
2007-07-27 0:31 ` Randy Dunlap
2007-07-27 0:31 ` Andrew Morton
1 sibling, 1 reply; 5+ messages in thread
From: Jesper Juhl @ 2007-07-27 0:17 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml, akpm
On 27/07/07, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Add text on using relevant mailing lists.
>
I'd add a little bit to that - see below
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> MAINTAINERS | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> --- linux-2623-rc1g2.orig/MAINTAINERS
> +++ linux-2623-rc1g2/MAINTAINERS
> @@ -23,15 +23,18 @@ trivial patch so apply some common sense
> 4. When you are happy with a change make it generally available for
> testing and await feedback.
>
> -5. Make a patch available to the relevant maintainer in the list. Use
> - 'diff -u' to make the patch easy to merge. Be prepared to get your
> - changes sent back with seemingly silly requests about formatting
> - and variable names. These aren't as silly as they seem. One
> - job the maintainers (and especially Linus) do is to keep things
> +5. Make a patch available to the relevant maintainer(s) and mailing
> + list(s). Use 'diff -u' to make the patch easy to merge. Be prepared
> + to get your changes sent back with seemingly silly requests about
> + formatting and variable names. These aren't as silly as they seem.
> + One job the maintainers (and especially Linus) do is to keep things
> looking the same. Sometimes this means that the clever hack in
> your driver to get around a problem actually needs to become a
> generalized kernel feature ready for next time.
>
> + Use the relevant mailing list(s) -- don't just send everything to
> + lkml (linux-kernel@vger.kernel.org).
+ Always including lkml in addition to more specific lists is usually OK.
> +
> PLEASE check your patch with the automated style checker
> (scripts/checkpatch.pl) to catch trival style violations.
> See Documentation/CodingStyle for guidance here.
--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MAINTAINERS: use relevant mailing lists
2007-07-27 0:08 [PATCH] MAINTAINERS: use relevant mailing lists Randy Dunlap
2007-07-27 0:17 ` Jesper Juhl
@ 2007-07-27 0:31 ` Andrew Morton
2007-07-27 17:53 ` Randy Dunlap
1 sibling, 1 reply; 5+ messages in thread
From: Andrew Morton @ 2007-07-27 0:31 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml
On Thu, 26 Jul 2007 17:08:57 -0700 Randy Dunlap <randy.dunlap@oracle.com> wrote:
> + Use the relevant mailing list(s) -- don't just send everything to
> + lkml (linux-kernel@vger.kernel.org).
True.
I personally only troll lkml for unloved patches, so I suspect that a
random patch which is sent to mailing-list-A and not to lkml has a higher
probability of getting lost than one which is sent to both lists. Plus
it'd be nice to get lkml's patch-to-noise ratio above one percent.
So I'd suggest that you rework the text here to make it clearer that
patches should go to lkml _and_ to the subsystem-specific mailing list.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MAINTAINERS: use relevant mailing lists
2007-07-27 0:17 ` Jesper Juhl
@ 2007-07-27 0:31 ` Randy Dunlap
0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2007-07-27 0:31 UTC (permalink / raw)
To: Jesper Juhl; +Cc: lkml, akpm
Jesper Juhl wrote:
> On 27/07/07, Randy Dunlap <randy.dunlap@oracle.com> wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> Add text on using relevant mailing lists.
>>
>
> I'd add a little bit to that - see below
>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> ---
>> MAINTAINERS | 13 ++++++++-----
>> 1 file changed, 8 insertions(+), 5 deletions(-)
>>
>> --- linux-2623-rc1g2.orig/MAINTAINERS
>> +++ linux-2623-rc1g2/MAINTAINERS
>> @@ -23,15 +23,18 @@ trivial patch so apply some common sense
>> 4. When you are happy with a change make it generally available for
>> testing and await feedback.
>>
>> -5. Make a patch available to the relevant maintainer in the list.
>> Use
>> - 'diff -u' to make the patch easy to merge. Be prepared to get
>> your
>> - changes sent back with seemingly silly requests about formatting
>> - and variable names. These aren't as silly as they seem. One
>> - job the maintainers (and especially Linus) do is to keep things
>> +5. Make a patch available to the relevant maintainer(s) and mailing
>> + list(s). Use 'diff -u' to make the patch easy to merge. Be
>> prepared
>> + to get your changes sent back with seemingly silly requests about
>> + formatting and variable names. These aren't as silly as they
>> seem.
>> + One job the maintainers (and especially Linus) do is to keep
>> things
>> looking the same. Sometimes this means that the clever hack in
>> your driver to get around a problem actually needs to become a
>> generalized kernel feature ready for next time.
>>
>> + Use the relevant mailing list(s) -- don't just send everything to
>> + lkml (linux-kernel@vger.kernel.org).
>
> + Always including lkml in addition to more specific lists is
> usually OK.
Well, I'd rather not say that, but that's the type of discussion
that this patch was looking for..
>> +
>> PLEASE check your patch with the automated style checker
>> (scripts/checkpatch.pl) to catch trival style violations.
>> See Documentation/CodingStyle for guidance here.
Thanks.
--
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] MAINTAINERS: use relevant mailing lists
2007-07-27 0:31 ` Andrew Morton
@ 2007-07-27 17:53 ` Randy Dunlap
0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2007-07-27 17:53 UTC (permalink / raw)
To: Andrew Morton; +Cc: lkml
On Thu, 26 Jul 2007 17:31:40 -0700 Andrew Morton wrote:
> On Thu, 26 Jul 2007 17:08:57 -0700 Randy Dunlap <randy.dunlap@oracle.com> wrote:
>
> > + Use the relevant mailing list(s) -- don't just send everything to
> > + lkml (linux-kernel@vger.kernel.org).
>
> True.
>
> I personally only troll lkml for unloved patches, so I suspect that a
> random patch which is sent to mailing-list-A and not to lkml has a higher
> probability of getting lost than one which is sent to both lists. Plus
> it'd be nice to get lkml's patch-to-noise ratio above one percent.
Yes (to P-N ratio).
I'd really like to see netdev patches going to netdev (only :)
and SCSI patches to linux-scsi (only), e.g., unless they actually
address some linux-arch like issue(s).
However, those maintainers are quite different regarding patch
handling. Maybe you could try to address some of that at that
Cambridge/September event.
> So I'd suggest that you rework the text here to make it clearer that
> patches should go to lkml _and_ to the subsystem-specific mailing list.
Patch is withdrawn.
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-07-27 17:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-27 0:08 [PATCH] MAINTAINERS: use relevant mailing lists Randy Dunlap
2007-07-27 0:17 ` Jesper Juhl
2007-07-27 0:31 ` Randy Dunlap
2007-07-27 0:31 ` Andrew Morton
2007-07-27 17:53 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox