From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764484AbXG0BAA (ORCPT ); Thu, 26 Jul 2007 21:00:00 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758449AbXG0A7u (ORCPT ); Thu, 26 Jul 2007 20:59:50 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:37276 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757064AbXG0A7t (ORCPT ); Thu, 26 Jul 2007 20:59:49 -0400 Date: Thu, 26 Jul 2007 17:59:29 -0700 From: Andrew Morton To: Stefan Richter Cc: Krzysztof Halasa , Josh Triplett , linux-kernel@vger.kernel.org, Linus Torvalds , linux-sparse@vger.kernel.org Subject: Re: [PATCH] CodingStyle: proscribe do-while without braces. Message-Id: <20070726175929.730fc0be.akpm@linux-foundation.org> In-Reply-To: <46A93F92.6050708@s5r6.in-berlin.de> References: <1185485822.4459.1.camel@josh-work.beaverton.ibm.com> <46A93F92.6050708@s5r6.in-berlin.de> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 27 Jul 2007 02:42:58 +0200 Stefan Richter wrote: > Krzysztof Halasa wrote: > > and even if I could, "always use" seems way too strong in this case. > > Besides, how about reorienting the CodingStyle text to the essential? > > (But leave the humorous language in --- the few parts that are inherited > from old versions of that file, now more and more being buried in dry > nitpicking.) If sparse has gone and added a warning for this then it is more than nitpicking. Reducing the amount of noise coming out of sparse is useful.