From: "J. Bruce Fields" <bfields@fieldses.org>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
neilb@suse.de
Subject: Re: [PATCH] lockd and nfsd endianness annotation fixes
Date: Thu, 26 Jul 2007 18:08:53 -0400 [thread overview]
Message-ID: <20070726220853.GN8125@fieldses.org> (raw)
In-Reply-To: <E1IE6Hd-0005Dl-Hu@ZenIV.linux.org.uk>
On Thu, Jul 26, 2007 at 05:33:49PM +0100, Al Viro wrote:
>
Oops, thanks; these are my fault.
(How are you finding these? I was assuming sparse, but running a make
-C2 just now I didn't see anything that would have suggested these
fixes. I'm using whatever's current in Fedora--it says 0.3-1.fc7. Do I
need something more recent?)
--b.
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> fs/lockd/svclock.c | 6 +++---
> fs/nfsd/nfs4xdr.c | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/lockd/svclock.c b/fs/lockd/svclock.c
> index b3efa45..a21e4bc 100644
> --- a/fs/lockd/svclock.c
> +++ b/fs/lockd/svclock.c
> @@ -335,10 +335,10 @@ static void nlmsvc_freegrantargs(struct nlm_rqst *call)
> /*
> * Deferred lock request handling for non-blocking lock
> */
> -static u32
> +static __be32
> nlmsvc_defer_lock_rqst(struct svc_rqst *rqstp, struct nlm_block *block)
> {
> - u32 status = nlm_lck_denied_nolocks;
> + __be32 status = nlm_lck_denied_nolocks;
>
> block->b_flags |= B_QUEUED;
>
> @@ -352,7 +352,7 @@ nlmsvc_defer_lock_rqst(struct svc_rqst *rqstp, struct nlm_block *block)
> status = nlm_drop_reply;
> }
> dprintk("lockd: nlmsvc_defer_lock_rqst block %p flags %d status %d\n",
> - block, block->b_flags, status);
> + block, block->b_flags, ntohl(status));
>
> return status;
> }
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index b3d55c6..8ef0964 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -2450,7 +2450,7 @@ nfsd4_encode_rename(struct nfsd4_compoundres *resp, __be32 nfserr, struct nfsd4_
> }
>
> static void
> -nfsd4_encode_secinfo(struct nfsd4_compoundres *resp, int nfserr,
> +nfsd4_encode_secinfo(struct nfsd4_compoundres *resp, __be32 nfserr,
> struct nfsd4_secinfo *secinfo)
> {
> int i = 0;
> --
> 1.5.3.GIT
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2007-07-26 22:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 16:33 [PATCH] lockd and nfsd endianness annotation fixes Al Viro
2007-07-26 22:08 ` J. Bruce Fields [this message]
2007-07-27 0:11 ` Neil Brown
2007-07-27 1:19 ` J. Bruce Fields
2007-07-27 1:38 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070726220853.GN8125@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox