From: Fenghua Yu <fenghua.yu@intel.com>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
venkatesh.pallipadi@intel.com
Subject: [PATCH] Fix uninitialized local variable "covered" in i386 acpi-cpufreq driver
Date: Thu, 26 Jul 2007 16:46:30 -0700 [thread overview]
Message-ID: <20070726234630.GA29288@linux-os.sc.intel.com> (raw)
In-Reply-To: <1181754124.6148.37.camel@localhost>
The local variable "covered" is used without initialization in i386 acpi-cpufreq
driver. The initial value of covered should be 0. The bug will cause memory leak
when hit. The following patch fixes this bug.
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
---
arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c b/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
index 6f846be..bfb4959 100644
--- a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
+++ b/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
@@ -511,7 +511,7 @@ acpi_cpufreq_guess_freq(struct acpi_cpufreq_data *data, unsigned int cpu)
static int acpi_cpufreq_early_init(void)
{
struct acpi_processor_performance *data;
- cpumask_t covered;
+ cpumask_t covered=0;
unsigned int i, j;
dprintk("acpi_cpufreq_early_init\n");
next parent reply other threads:[~2007-07-26 23:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1181754124.6148.37.camel@localhost>
2007-07-26 23:46 ` Fenghua Yu [this message]
2007-07-27 0:12 ` [PATCH] Fix uninitialized local variable "covered" in i386 acpi-cpufreq driver Andrew Morton
2007-07-27 0:16 ` Andrew Morton
2007-07-27 0:46 ` Yu, Fenghua
[not found] ` <20070613172106.GA3002@frankl.hpl.hp.com>
2007-07-27 0:01 ` Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070726234630.GA29288@linux-os.sc.intel.com \
--to=fenghua.yu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox