Re: [PATCH] LinuxPPS - definitive version

David Woodhouse
2007-07-23T19:48:32Z

On Mon, 2007-07-23 at 12:28 -0700, Andrew Morton wrote:
> On Mon, 23 Jul 2007 14:35:16 +0100
> David Woodhouse <dwmw2@infradead.org> wrote:
>
> > Please feed it to scripts/checkpatch.pl -- you can ignore all the
> > warnings about lines greater than 80 characters, and the complete crap
> > about "declaring multiple variables together should be avoided", but
> > some of what it points out is valid.
>
> The above are David's opinions. Many, probably most kernel developers do not
> agree with them.

Linus called the 80-column thing a 'Nazi dream' and I'm inclined to
agree with him. It's something to bear in mind, of course, but sometimes
it's best ignored.

And the 'declaring multiple variables together' is something I've
_never_ heard of. Might be applicable if you're actually giving them
initial values, but just declaring them together is fine, surely?

--
dwmw2