RE: [PATCH] TSDEV - Don't flood dmesg with removal warnings

RE: [PATCH] TSDEV - Don't flood dmesg with removal warnings

[Parag Warudkar]

Ignore my previous whitespace damaged patch. This one should be good.

tsdev.c warns about scheduled removal each time tsdev_open is called -
So even for a default boot I get to see the warning 3 times -

[  340.537078] tsdev (compaq touchscreen emulation) is scheduled for
removal.
[  340.537081] See Documentation/feature-removal-schedule.txt for details.
[  340.550314] tsdev (compaq touchscreen emulation) is scheduled for
removal.
[  340.550318] See Documentation/feature-removal-schedule.txt for details.
[  340.565065] tsdev (compaq touchscreen emulation) is scheduled for
removal.
[  340.565068] See Documentation/feature-removal-schedule.txt for details.

Move the warning to tsdev_init() from tsdev_open so we don't end up
printing a large string in dmesg everytime tsdev_open is called.

Signed-Off-by: Parag Warudkar <parag.warudkar@gmail.com>

--- linux-git/drivers/input/tsdev.c.orig	2007-07-27 10:32:51.000000000 -0400
+++ linux-git/drivers/input/tsdev.c	2007-07-27 10:34:46.000000000 -0400
@@ -154,10 +154,6 @@
  	struct tsdev *tsdev;
  	int error;

-	printk(KERN_WARNING "tsdev (compaq touchscreen emulation) is scheduled "
-		"for removal.\nSee Documentation/feature-removal-schedule.txt "
-		"for details.\n");
-
  	if (i >= TSDEV_MINORS)
  		return -ENODEV;

@@ -521,6 +517,9 @@

  static int __init tsdev_init(void)
  {
+	printk(KERN_WARNING "tsdev (compaq touchscreen emulation) is scheduled "
+		"for removal.\nSee Documentation/feature-removal-schedule.txt "
+		"for details.\n");
  	return input_register_handler(&tsdev_handler);
  }

Re: [PATCH] TSDEV - Don't flood dmesg with removal warnings

[Dmitry Torokhov]

Hi Parag,

On Friday 27 July 2007 10:43, Parag Warudkar wrote:
> Ignore my previous whitespace damaged patch. This one should be good.
> 
> tsdev.c warns about scheduled removal each time tsdev_open is called -
> So even for a default boot I get to see the warning 3 times -
> 
> [  340.537078] tsdev (compaq touchscreen emulation) is scheduled for
> removal.
> [  340.537081] See Documentation/feature-removal-schedule.txt for details.
> [  340.550314] tsdev (compaq touchscreen emulation) is scheduled for
> removal.
> [  340.550318] See Documentation/feature-removal-schedule.txt for details.
> [  340.565065] tsdev (compaq touchscreen emulation) is scheduled for
> removal.
> [  340.565068] See Documentation/feature-removal-schedule.txt for details.
> 
> Move the warning to tsdev_init() from tsdev_open so we don't end up
> printing a large string in dmesg everytime tsdev_open is called.
>

The printk was moved per Andrew's request to make it more annoying.
Obviously it is working ;) Do you know what is opening /dev/input/tsX
nodes?

-- 
Dmitry

Re: [PATCH] TSDEV - Don't flood dmesg with removal warnings

[Parag Warudkar]

Hi

On 7/29/07, Dmitry Torokhov <dtor@insightbb.com> wrote:
> Hi Parag,
>
> On Friday 27 July 2007 10:43, Parag Warudkar wrote:
> > Ignore my previous whitespace damaged patch. This one should be good.
> >
> > tsdev.c warns about scheduled removal each time tsdev_open is called -
> > So even for a default boot I get to see the warning 3 times -
>
> The printk was moved per Andrew's request to make it more annoying.

The fact that tsdev loads on most people's laptop for no reason and
then gets opened 3 times ought to be annoying enough to make people
delete that module :)

> Obviously it is working ;) Do you know what is opening /dev/input/tsX
> nodes?
>

Who else but Xorg and the boat load of totally irrelevant crap (wacom
etc.) that Ubuntu fills up in xorg.conf (perhaps)? Frankly I don't
know for sure.

Anyway the stated removal is only 3 months away so I guess people can
live with the dmesg annoyance until that time.

Parag

[PATCH] TSDEV - Don't flood dmesg with removal warnings

[Parag Warudkar]

tsdev.c warns about scheduled removal each time tsdev_open is called - 
So even for a default boot I get to see the warning 3 times -

[  340.537078] tsdev (compaq touchscreen emulation) is scheduled for 
removal.
[  340.537081] See Documentation/feature-removal-schedule.txt for details.
[  340.550314] tsdev (compaq touchscreen emulation) is scheduled for 
removal.
[  340.550318] See Documentation/feature-removal-schedule.txt for details.
[  340.565065] tsdev (compaq touchscreen emulation) is scheduled for 
removal.
[  340.565068] See Documentation/feature-removal-schedule.txt for details.

Move the warning to tsdev_init() from tsdev_open so we don't end up 
printing a large string in dmesg everytime tsdev_open is called.

Signed-Off-by: Parag Warudkar <parag.warudkar@gmail.com>

--- linux-git/drivers/input/tsdev.c.orig    2007-07-27 
09:57:14.000000000 -0400
+++ linux-git/drivers/input/tsdev.c    2007-07-27 09:58:09.000000000 -0400
@@ -154,10 +154,6 @@
     struct tsdev *tsdev;
     int error;
 
-    printk(KERN_WARNING "tsdev (compaq touchscreen emulation) is 
scheduled "
-        "for removal.\nSee Documentation/feature-removal-schedule.txt "
-        "for details.\n");
-
     if (i >= TSDEV_MINORS)
         return -ENODEV;
 
@@ -521,6 +517,9 @@
 
 static int __init tsdev_init(void)
 {
+    printk(KERN_WARNING "tsdev (compaq touchscreen emulation) is 
scheduled "
+        "for removal.\nSee Documentation/feature-removal-schedule.txt "
+        "for details.\n");
     return input_register_handler(&tsdev_handler);
 }