From: Jens Axboe <jens.axboe@oracle.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bsg: Fix warning with CONFIG_BLK_DEV_BSG=n
Date: Sun, 29 Jul 2007 12:54:58 +0200 [thread overview]
Message-ID: <20070729105458.GH32258@kernel.dk> (raw)
In-Reply-To: <ada6443vphh.fsf@cisco.com>
On Sat, Jul 28 2007, Roland Dreier wrote:
> The current stub definitions of bsg_register_queue() and
> bsg_unregister_queue() as macros leads to
>
> drivers/scsi/scsi_sysfs.c: In function 'scsi_sysfs_add_sdev':
> drivers/scsi/scsi_sysfs.c:718: warning: unused variable 'rq'
>
> because the first parameter of bsg_register_queue() is completely
> discarded. As akpm says, "program in C, not in cpp." We might as
> well get a little bit better type-checking when we fix this by
> converting the stubs to empty inline functions.
James should already have that patch queued for inclusion since last
week.
--
Jens Axboe
next prev parent reply other threads:[~2007-07-29 10:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-29 3:49 [PATCH] bsg: Fix warning with CONFIG_BLK_DEV_BSG=n Roland Dreier
2007-07-29 10:54 ` Jens Axboe [this message]
2007-07-29 13:50 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070729105458.GH32258@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox