* [2.6 patch] make abituguru3_read_increment_offset() static
@ 2007-07-29 14:57 Adrian Bunk
2007-07-29 16:08 ` [lm-sensors] " Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2007-07-29 14:57 UTC (permalink / raw)
To: Hans de Goede, Mark M. Hoffman; +Cc: lm-sensors, linux-kernel
abituguru3_read_increment_offset() can become static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
--- linux-2.6.23-rc1-mm1/drivers/hwmon/abituguru3.c.old 2007-07-26 08:56:33.000000000 +0200
+++ linux-2.6.23-rc1-mm1/drivers/hwmon/abituguru3.c 2007-07-26 08:57:00.000000000 +0200
@@ -691,8 +691,9 @@
/* Sensor settings are stored 1 byte per offset with the bytes
placed add consecutive offsets. */
-int abituguru3_read_increment_offset(struct abituguru3_data *data, u8 bank,
- u8 offset, u8 count, u8 *buf, int offset_count)
+static int abituguru3_read_increment_offset(struct abituguru3_data *data,
+ u8 bank, u8 offset, u8 count,
+ u8 *buf, int offset_count)
{
int i, x;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [2.6 patch] make abituguru3_read_increment_offset() static
2007-07-29 14:57 [2.6 patch] make abituguru3_read_increment_offset() static Adrian Bunk
@ 2007-07-29 16:08 ` Hans de Goede
2007-07-29 18:45 ` Mark M. Hoffman
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2007-07-29 16:08 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Mark M. Hoffman, linux-kernel, lm-sensors
Adrian Bunk wrote:
> abituguru3_read_increment_offset() can become static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Looks good, good catch.
Acked-by: Hans de Goede <j.w.r.degoede@hhs.nl>
>
> ---
> --- linux-2.6.23-rc1-mm1/drivers/hwmon/abituguru3.c.old 2007-07-26 08:56:33.000000000 +0200
> +++ linux-2.6.23-rc1-mm1/drivers/hwmon/abituguru3.c 2007-07-26 08:57:00.000000000 +0200
> @@ -691,8 +691,9 @@
>
> /* Sensor settings are stored 1 byte per offset with the bytes
> placed add consecutive offsets. */
> -int abituguru3_read_increment_offset(struct abituguru3_data *data, u8 bank,
> - u8 offset, u8 count, u8 *buf, int offset_count)
> +static int abituguru3_read_increment_offset(struct abituguru3_data *data,
> + u8 bank, u8 offset, u8 count,
> + u8 *buf, int offset_count)
> {
> int i, x;
>
>
>
> _______________________________________________
> lm-sensors mailing list
> lm-sensors@lm-sensors.org
> http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [lm-sensors] [2.6 patch] make abituguru3_read_increment_offset() static
2007-07-29 16:08 ` [lm-sensors] " Hans de Goede
@ 2007-07-29 18:45 ` Mark M. Hoffman
0 siblings, 0 replies; 3+ messages in thread
From: Mark M. Hoffman @ 2007-07-29 18:45 UTC (permalink / raw)
To: Hans de Goede; +Cc: Adrian Bunk, linux-kernel, lm-sensors
Hi:
* Hans de Goede <j.w.r.degoede@hhs.nl> [2007-07-29 18:08:46 +0200]:
> Adrian Bunk wrote:
> >abituguru3_read_increment_offset() can become static.
> >
> >Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> Looks good, good catch.
>
> Acked-by: Hans de Goede <j.w.r.degoede@hhs.nl>
>
> >
> >---
> >--- linux-2.6.23-rc1-mm1/drivers/hwmon/abituguru3.c.old 2007-07-26
> >08:56:33.000000000 +0200
> >+++ linux-2.6.23-rc1-mm1/drivers/hwmon/abituguru3.c 2007-07-26
> >08:57:00.000000000 +0200
> >@@ -691,8 +691,9 @@
> >
> > /* Sensor settings are stored 1 byte per offset with the bytes
> > placed add consecutive offsets. */
> >-int abituguru3_read_increment_offset(struct abituguru3_data *data, u8
> >bank,
> >- u8 offset, u8 count, u8 *buf, int offset_count)
> >+static int abituguru3_read_increment_offset(struct abituguru3_data *data,
> >+ u8 bank, u8 offset, u8 count,
> >+ u8 *buf, int offset_count)
> > {
> > int i, x;
> >
> >
Applied to hwmon-2.6.git/testing, thanks.
--
Mark M. Hoffman
mhoffman@lightlink.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-29 18:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-29 14:57 [2.6 patch] make abituguru3_read_increment_offset() static Adrian Bunk
2007-07-29 16:08 ` [lm-sensors] " Hans de Goede
2007-07-29 18:45 ` Mark M. Hoffman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox