* [2.6 patch] mm/page_alloc.c: make code static
@ 2007-07-29 14:58 Adrian Bunk
2007-07-30 10:28 ` Mel Gorman
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2007-07-29 14:58 UTC (permalink / raw)
To: Mel Gorman; +Cc: linux-kernel
This patch makes needlessly global code static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
mm/page_alloc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux-2.6.23-rc1-mm1/mm/page_alloc.c.old 2007-07-26 15:09:24.000000000 +0200
+++ linux-2.6.23-rc1-mm1/mm/page_alloc.c 2007-07-26 15:11:16.000000000 +0200
@@ -142,7 +142,7 @@
static unsigned long __meminitdata node_boundary_end_pfn[MAX_NUMNODES];
#endif /* CONFIG_MEMORY_HOTPLUG_RESERVE */
unsigned long __initdata required_kernelcore;
- unsigned long __initdata required_movablecore;
+ static unsigned long __initdata required_movablecore;
unsigned long __meminitdata zone_movable_pfn[MAX_NUMNODES];
/* movable_zone is the "real" zone pages in ZONE_MOVABLE are taken from */
@@ -3686,7 +3686,7 @@
return max_pfn;
}
-unsigned long __init early_calculate_totalpages(void)
+static unsigned long __init early_calculate_totalpages(void)
{
int i;
unsigned long totalpages = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] mm/page_alloc.c: make code static
2007-07-29 14:58 [2.6 patch] mm/page_alloc.c: make code static Adrian Bunk
@ 2007-07-30 10:28 ` Mel Gorman
0 siblings, 0 replies; 2+ messages in thread
From: Mel Gorman @ 2007-07-30 10:28 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
On (29/07/07 16:58), Adrian Bunk didst pronounce:
> This patch makes needlessly global code static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
Seems fair.
Acked-by: Mel Gorman <mel@csn.ul.ie>
> ---
>
> mm/page_alloc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-2.6.23-rc1-mm1/mm/page_alloc.c.old 2007-07-26 15:09:24.000000000 +0200
> +++ linux-2.6.23-rc1-mm1/mm/page_alloc.c 2007-07-26 15:11:16.000000000 +0200
> @@ -142,7 +142,7 @@
> static unsigned long __meminitdata node_boundary_end_pfn[MAX_NUMNODES];
> #endif /* CONFIG_MEMORY_HOTPLUG_RESERVE */
> unsigned long __initdata required_kernelcore;
> - unsigned long __initdata required_movablecore;
> + static unsigned long __initdata required_movablecore;
> unsigned long __meminitdata zone_movable_pfn[MAX_NUMNODES];
>
> /* movable_zone is the "real" zone pages in ZONE_MOVABLE are taken from */
> @@ -3686,7 +3686,7 @@
> return max_pfn;
> }
>
> -unsigned long __init early_calculate_totalpages(void)
> +static unsigned long __init early_calculate_totalpages(void)
> {
> int i;
> unsigned long totalpages = 0;
--
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-30 10:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-29 14:58 [2.6 patch] mm/page_alloc.c: make code static Adrian Bunk
2007-07-30 10:28 ` Mel Gorman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox