* [2.6 patch] lib/ioremap.c should #include <linux/io.h>
@ 2007-07-05 23:22 Adrian Bunk
2007-07-06 7:40 ` Haavard Skinnemoen
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2007-07-05 23:22 UTC (permalink / raw)
To: Haavard Skinnemoen; +Cc: linux-kernel
Every file should include the headers containing the prototypes for
its global functions.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
--- linux-2.6.22-rc6-mm1/lib/ioremap.c.old 2007-07-03 05:02:10.000000000 +0200
+++ linux-2.6.22-rc6-mm1/lib/ioremap.c 2007-07-03 05:02:22.000000000 +0200
@@ -8,6 +8,7 @@
#include <linux/vmalloc.h>
#include <linux/mm.h>
#include <linux/sched.h>
+#include <linux/io.h>
#include <asm/cacheflush.h>
#include <asm/pgtable.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] lib/ioremap.c should #include <linux/io.h>
2007-07-05 23:22 Adrian Bunk
@ 2007-07-06 7:40 ` Haavard Skinnemoen
0 siblings, 0 replies; 3+ messages in thread
From: Haavard Skinnemoen @ 2007-07-06 7:40 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel, Andrew Morton
On Fri, 6 Jul 2007 01:22:28 +0200
Adrian Bunk <bunk@stusta.de> wrote:
> Every file should include the headers containing the prototypes for
> its global functions.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Can't argue with that.
Acked-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
> ---
> --- linux-2.6.22-rc6-mm1/lib/ioremap.c.old 2007-07-03 05:02:10.000000000 +0200
> +++ linux-2.6.22-rc6-mm1/lib/ioremap.c 2007-07-03 05:02:22.000000000 +0200
> @@ -8,6 +8,7 @@
> #include <linux/vmalloc.h>
> #include <linux/mm.h>
> #include <linux/sched.h>
> +#include <linux/io.h>
> #include <asm/cacheflush.h>
> #include <asm/pgtable.h>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [2.6 patch] lib/ioremap.c should #include <linux/io.h>
@ 2007-07-29 15:02 Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2007-07-29 15:02 UTC (permalink / raw)
To: Andrew Morton; +Cc: Haavard Skinnemoen, linux-kernel
Every file should include the headers containing the prototypes for
its global functions (in this case ioremap_page_range()).
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
---
This patch has been sent on:
- 6 Jul 2007
--- linux-2.6.22-rc6-mm1/lib/ioremap.c.old 2007-07-03 05:02:10.000000000 +0200
+++ linux-2.6.22-rc6-mm1/lib/ioremap.c 2007-07-03 05:02:22.000000000 +0200
@@ -8,6 +8,7 @@
#include <linux/vmalloc.h>
#include <linux/mm.h>
#include <linux/sched.h>
+#include <linux/io.h>
#include <asm/cacheflush.h>
#include <asm/pgtable.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-07-29 15:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-29 15:02 [2.6 patch] lib/ioremap.c should #include <linux/io.h> Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2007-07-05 23:22 Adrian Bunk
2007-07-06 7:40 ` Haavard Skinnemoen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox