From: mel@skynet.ie (Mel Gorman)
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] mm/page_alloc.c: make code static
Date: Mon, 30 Jul 2007 11:28:50 +0100 [thread overview]
Message-ID: <20070730102850.GA13683@skynet.ie> (raw)
In-Reply-To: <20070729145802.GT16817@stusta.de>
On (29/07/07 16:58), Adrian Bunk didst pronounce:
> This patch makes needlessly global code static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
Seems fair.
Acked-by: Mel Gorman <mel@csn.ul.ie>
> ---
>
> mm/page_alloc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-2.6.23-rc1-mm1/mm/page_alloc.c.old 2007-07-26 15:09:24.000000000 +0200
> +++ linux-2.6.23-rc1-mm1/mm/page_alloc.c 2007-07-26 15:11:16.000000000 +0200
> @@ -142,7 +142,7 @@
> static unsigned long __meminitdata node_boundary_end_pfn[MAX_NUMNODES];
> #endif /* CONFIG_MEMORY_HOTPLUG_RESERVE */
> unsigned long __initdata required_kernelcore;
> - unsigned long __initdata required_movablecore;
> + static unsigned long __initdata required_movablecore;
> unsigned long __meminitdata zone_movable_pfn[MAX_NUMNODES];
>
> /* movable_zone is the "real" zone pages in ZONE_MOVABLE are taken from */
> @@ -3686,7 +3686,7 @@
> return max_pfn;
> }
>
> -unsigned long __init early_calculate_totalpages(void)
> +static unsigned long __init early_calculate_totalpages(void)
> {
> int i;
> unsigned long totalpages = 0;
--
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
prev parent reply other threads:[~2007-07-30 10:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-29 14:58 [2.6 patch] mm/page_alloc.c: make code static Adrian Bunk
2007-07-30 10:28 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070730102850.GA13683@skynet.ie \
--to=mel@skynet.ie \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox