From: Andrew Morton <akpm@linux-foundation.org>
To: Joe Jin <joe.jin@oracle.com>
Cc: gurudas pai <gurudas.pai@oracle.com>,
torvalds@linux-foundation.org, jens.axboe@oracle.com,
linux-kernel@vger.kernel.org, wen.gang.wang@oracle.com,
Badari Pulavarty <pbadari@us.ibm.com>,
Zach Brown <zach.brown@oracle.com>
Subject: Re: [PATCH] add check do_direct_IO() return val
Date: Mon, 30 Jul 2007 13:53:16 -0700 [thread overview]
Message-ID: <20070730135316.2ce21b28.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070728034719.GA24448@joejin-pc.cn.oracle.com>
On Sat, 28 Jul 2007 11:47:19 +0800
Joe Jin <joe.jin@oracle.com> wrote:
> > I tested Andrew's patch and panic was gone but got few ENOTBLK.
> > So I tried with Joe's patch , both panic and ENOTBLK are gone now.
> > But in Joe's patch if (ret == -ENOTBLK && (rw & WRITE)), dio_cleanup(dio)
> > was not getting called because of break. So I moved dio_cleanup just
> > after if (ret).
>
> Guru, actually, break from the loop with ENOTBLK will call dio_cleanup
> at leater, if call it too early, that means will put_page(), maybe cause
> other panic.
>
fyi, I dropped the earlier patch and now we have nothing. Please let's get all
this sorted out in time for 2.6.23. Which is still many weeks away so there is
plenty of time to prepare something which was carefully reviewed and well-tested,
thanks.
next prev parent reply other threads:[~2007-07-30 20:53 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 9:04 [PATCH] add check do_direct_IO() return val Joe Jin
2007-07-27 5:13 ` Andrew Morton
2007-07-27 7:15 ` Joe Jin
2007-07-27 7:31 ` Dave Young
2007-07-27 7:44 ` Joe Jin
2007-07-27 12:37 ` gurudas pai
2007-07-28 3:47 ` Joe Jin
2007-07-30 20:53 ` Andrew Morton [this message]
2007-07-30 21:09 ` Zach Brown
2007-07-30 21:24 ` Badari Pulavarty
2007-07-30 21:45 ` Zach Brown
2007-07-30 21:58 ` Badari Pulavarty
2007-07-30 21:58 ` Zach Brown
2007-07-30 23:38 ` Zach Brown
2007-07-31 0:15 ` Badari Pulavarty
2007-07-31 0:17 ` Badari Pulavarty
2007-07-31 0:53 ` Joe Jin
2007-07-31 3:45 ` Badari
2007-07-31 4:35 ` Joe Jin
2007-07-31 5:01 ` Badari
2007-07-31 22:25 ` Badari Pulavarty
2007-07-31 22:34 ` Andrew Morton
2007-07-31 22:59 ` Linus Torvalds
2007-07-31 23:16 ` Zach Brown
2007-08-01 1:36 ` Joe Jin
2007-08-01 11:40 ` gurudas pai
2007-07-31 23:04 ` Badari Pulavarty
2007-07-31 23:14 ` Zach Brown
2007-08-01 1:11 ` Joe Jin
2007-07-27 8:09 ` gurudas pai
2007-07-27 5:13 ` wengang wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070730135316.2ce21b28.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=gurudas.pai@oracle.com \
--cc=jens.axboe@oracle.com \
--cc=joe.jin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=wen.gang.wang@oracle.com \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox