From: Andrew Morton <akpm@linux-foundation.org>
To: "Christian P. Schmidt" <charlie@digadd.de>
Cc: linux-kernel@vger.kernel.org, Russell King <rmk@arm.linux.org.uk>
Subject: Re: ttyS1: LSR safety check engaged! - misidentification?
Date: Mon, 30 Jul 2007 15:59:39 -0700 [thread overview]
Message-ID: <20070730155939.9bf43314.akpm@linux-foundation.org> (raw)
In-Reply-To: <46ACB1C2.6030701@digadd.de>
On Sun, 29 Jul 2007 18:26:58 +0300
"Christian P. Schmidt" <charlie@digadd.de> wrote:
> Hi all,
>
> Ever since Kernel 2.6.21(rc) or so I'm plagued with this message,
> disabling my serial ports that have been working perfectly from 2.6.14
> till that day (and are still doing so, given that I continuously remove
> the code from the source).
> Actually I cannot blame the code, but it seems that on both of my
> laptops the LSR is actually not readable. So, is there any plan to
> remove that piece of code again, or at least change it so it can be
> disabled conditionally?
>
afaict this code:
/*
* At this point, there's no way the LSR could still be 0xff;
* if it is, then bail out, because there's likely no UART
* here.
*/
if (!(up->port.flags & UPF_BUGGY_UART) &&
(serial_inp(up, UART_LSR) == 0xff)) {
printk("ttyS%d: LSR safety check engaged!\n", up->port.line);
return -ENODEV;
}
is unchanged since 2.6.1, so I'm unsure what change you're proposing here?
prev parent reply other threads:[~2007-07-30 23:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-29 15:26 ttyS1: LSR safety check engaged! - misidentification? Christian P. Schmidt
2007-07-30 22:59 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070730155939.9bf43314.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=charlie@digadd.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox