[PATCH] usbhid: add ASUS LCM to the blacklist

[PATCH] usbhid: add ASUS LCM to the blacklist

[Christian Lamparter]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]


Some of ASUS' notebooks (e.g G Series) include a tiny oled display, which is 
attached to an internal USB bus. Unfortunatly the device reports a wrong
DeviceDescriptor and is therefore identified as a HID device...

Signed-off-by: Christian Lamparter <chunkeey@web.de>
CC: linux-input@atrey.karlin.mff.cuni.cz
CC: linux-usb-devel@lists.sourceforge.net

---
(keep the cc!)
for those who are interested in the userspace display driver:
https://launchpad.net/asusoled  


[-- Attachment #2: asus-lcm-hid-blacklist.diff --]
[-- Type: text/x-diff, Size: 864 bytes --]

diff -up drivers/hid/usbhid/hid-quirks.c.orig drivers/hid/usbhid/hid-quirks.c
--- a/drivers/hid/usbhid/hid-quirks.c.orig	2007-07-24 02:23:36.000000000 +0200
+++ b/drivers/hid/usbhid/hid-quirks.c	2007-07-24 02:25:26.000000000 +0200
@@ -63,6 +63,9 @@
 #define USB_DEVICE_ID_APPLE_GEYSER1_TP_ONLY	0x030b
 #define USB_DEVICE_ID_APPLE_IR		0x8240
 
+#define USB_VENDOR_ID_ASUS		0x0b05
+#define USB_DEVICE_ID_ASUS_LCM		0x1726
+
 #define USB_VENDOR_ID_ATEN		0x0557
 #define USB_DEVICE_ID_ATEN_UC100KM	0x2004
 #define USB_DEVICE_ID_ATEN_CS124U	0x2202
@@ -452,6 +455,8 @@ static const struct hid_blacklist {
 	{ USB_VENDOR_ID_CYPRESS, USB_DEVICE_ID_CYPRESS_BARCODE_1, HID_QUIRK_SWAPPED_MIN_MAX },
 	{ USB_VENDOR_ID_CYPRESS, USB_DEVICE_ID_CYPRESS_BARCODE_2, HID_QUIRK_SWAPPED_MIN_MAX },
 
+	{ USB_VENDOR_ID_ASUS, USB_DEVICE_ID_ASUS_LCM, HID_QUIRK_IGNORE},
+
 	{ 0, 0 }
 };
 

Re: [PATCH] usbhid: add ASUS LCM to the blacklist

[Andrew Morton]

On Tue, 24 Jul 2007 02:28:39 +0200 Christian Lamparter <chunkeey@web.de> wrote:

> Some of ASUS' notebooks (e.g G Series) include a tiny oled display, which is 
> attached to an internal USB bus. Unfortunatly the device reports a wrong
> DeviceDescriptor and is therefore identified as a HID device...
> 
> Signed-off-by: Christian Lamparter <chunkeey@web.de>
> CC: linux-input@atrey.karlin.mff.cuni.cz
> CC: linux-usb-devel@lists.sourceforge.net
> 
> ---
> (keep the cc!)
> for those who are interested in the userspace display driver:
> https://launchpad.net/asusoled  
> 
> 
> 
> [asus-lcm-hid-blacklist.diff  text/x-diff (865B)]
> diff -up drivers/hid/usbhid/hid-quirks.c.orig drivers/hid/usbhid/hid-quirks.c
> --- a/drivers/hid/usbhid/hid-quirks.c.orig	2007-07-24 02:23:36.000000000 +0200
> +++ b/drivers/hid/usbhid/hid-quirks.c	2007-07-24 02:25:26.000000000 +0200
> @@ -63,6 +63,9 @@
>  #define USB_DEVICE_ID_APPLE_GEYSER1_TP_ONLY	0x030b
>  #define USB_DEVICE_ID_APPLE_IR		0x8240
>  
> +#define USB_VENDOR_ID_ASUS		0x0b05
> +#define USB_DEVICE_ID_ASUS_LCM		0x1726
> +
>  #define USB_VENDOR_ID_ATEN		0x0557
>  #define USB_DEVICE_ID_ATEN_UC100KM	0x2004
>  #define USB_DEVICE_ID_ATEN_CS124U	0x2202
> @@ -452,6 +455,8 @@ static const struct hid_blacklist {
>  	{ USB_VENDOR_ID_CYPRESS, USB_DEVICE_ID_CYPRESS_BARCODE_1, HID_QUIRK_SWAPPED_MIN_MAX },
>  	{ USB_VENDOR_ID_CYPRESS, USB_DEVICE_ID_CYPRESS_BARCODE_2, HID_QUIRK_SWAPPED_MIN_MAX },
>  
> +	{ USB_VENDOR_ID_ASUS, USB_DEVICE_ID_ASUS_LCM, HID_QUIRK_IGNORE},
> +
>  	{ 0, 0 }
>  };

diff -p said that the second hnk goes into the hid_blacklist[] array, but
your patch actually places it in the hid_rdesc_blacklist[] array.

I suspect what we have here is a diff against 2.6.22?  Things changed
a lot since then - please prepare patches against the latest kernel you can get
your hands on, thanks.

Re: [PATCH] usbhid: add ASUS LCM to the blacklist

[Christian Lamparter]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

Some of ASUS' notebooks (e.g G Series) include a tiny oled display, which is 
attached to an internal USB bus. Unfortunatly the device reports a wrong
DeviceDescriptor and is therefore identified as a HID device...

Signed-off-by: Christian Lamparter <chunkeey@web.de>
CC: linux-input@atrey.karlin.mff.cuni.cz
CC: linux-usb-devel@lists.sourceforge.net

---
Right! the last _two_ patches/resends were made from 2.6.22-*,
this time however, it's diffed from 2.6.23-rc1-git3... 
(I hope it get's merged before someone else has already changed
the line numbers again. ;) )


[-- Attachment #2: asus-lcm-hid-quirk.diff --]
[-- Type: text/x-diff, Size: 840 bytes --]

diff -up drivers/hid/usbhid/hid-quirks.c.orig drivers/hid/usbhid/hid-quirks.c
--- a/drivers/hid/usbhid/hid-quirks.c.orig	2007-07-27 00:23:36.000000000 +0200
+++ b/drivers/hid/usbhid/hid-quirks.c	2007-07-27 00:25:26.000000000 +0200
@@ -63,6 +63,9 @@
 #define USB_DEVICE_ID_APPLE_GEYSER1_TP_ONLY	0x030b
 #define USB_DEVICE_ID_APPLE_IR		0x8240
 
+#define USB_VENDOR_ID_ASUS		0x0b05
+#define USB_DEVICE_ID_ASUS_LCM		0x1726
+
 #define USB_VENDOR_ID_ATEN		0x0557
 #define USB_DEVICE_ID_ATEN_UC100KM	0x2004
 #define USB_DEVICE_ID_ATEN_CS124U	0x2202
@@ -464,6 +467,8 @@ static const struct hid_blacklist {
 	{ USB_VENDOR_ID_DELL, USB_DEVICE_ID_DELL_W7658, HID_QUIRK_RESET_LEDS },
 	{ USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_KBD, HID_QUIRK_RESET_LEDS },
 
+	{ USB_VENDOR_ID_ASUS, USB_DEVICE_ID_ASUS_LCM, HID_QUIRK_IGNORE},
+
 	{ 0, 0 }
 };
 

Re: [PATCH] usbhid: add ASUS LCM to the blacklist

[Jiri Kosina]

On Fri, 27 Jul 2007, Christian Lamparter wrote:

> Some of ASUS' notebooks (e.g G Series) include a tiny oled display, which is 
> attached to an internal USB bus. Unfortunatly the device reports a wrong
> DeviceDescriptor and is therefore identified as a HID device...

Hi Christian,

I have slightly modified your patch (let's keep the hid_blacklist[] 
properly sorted) and applied it into my tree.

Thanks,

-- 
Jiri Kosina

Re: [PATCH] usbhid: add ASUS LCM to the blacklist

[Chr]

On Monday, 30. July 2007, Jiri Kosina wrote:
> On Fri, 27 Jul 2007, Christian Lamparter wrote:
> 
> > Some of ASUS' notebooks (e.g G Series) include a tiny oled display, which is 
> > attached to an internal USB bus. Unfortunatly the device reports a wrong
> > DeviceDescriptor and is therefore identified as a HID device...
> 
> Hi Christian,
> 
> I have slightly modified your patch (let's keep the hid_blacklist[] 
> properly sorted) and applied it into my tree.

Ok, found it " hid_blacklist is alphabetically sorted blacklist by quirk type. "
But is there a Order for the bitfields? e.g

shouldn't: hid-quriks.c (line 439, 440)

{ USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_FOUNTAIN_ANSI, 
HID_QUIRK_POWERBOOK_HAS_FN | HID_QUIRK_IGNORE_MOUSE } 

be:
{..., ..., HID_QUIRK_IGNORE_MOUSE | HID_QUIRK_POWERBOOK_HAS_FN }


Anyway, thanks for merging! 
	Chr.
 

Re: [PATCH] usbhid: add ASUS LCM to the blacklist

[Jiri Kosina]

On Mon, 30 Jul 2007, Chr wrote:

> Ok, found it " hid_blacklist is alphabetically sorted blacklist by quirk 
> type. " But is there a Order for the bitfields? e.g
> shouldn't: hid-quriks.c (line 439, 440)
> { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_FOUNTAIN_ANSI, 
> HID_QUIRK_POWERBOOK_HAS_FN | HID_QUIRK_IGNORE_MOUSE } 
> be:
> {..., ..., HID_QUIRK_IGNORE_MOUSE | HID_QUIRK_POWERBOOK_HAS_FN }

This could be a possible cleanup for hid_blacklist[], if you are going to 
make a patch I will happily accept it.

Thanks,

-- 
Jiri Kosina

Cleaning up the USBHID's blacklist.

[Chr]

On Tuesday, 31. July 2007, Jiri Kosina wrote:
> On Mon, 30 Jul 2007, Chr wrote:
> 
> > Ok, found it " hid_blacklist is alphabetically sorted blacklist by quirk 
> > type. " But is there a Order for the bitfields? e.g
> > shouldn't: hid-quriks.c (line 439, 440)
> > { USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_FOUNTAIN_ANSI, 
> > HID_QUIRK_POWERBOOK_HAS_FN | HID_QUIRK_IGNORE_MOUSE } 
> > be:
> > {..., ..., HID_QUIRK_IGNORE_MOUSE | HID_QUIRK_POWERBOOK_HAS_FN }
> 
> This could be a possible cleanup for hid_blacklist[], if you are going to 
> make a patch I will happily accept it.
> 
> Thanks,
> 
Ok! I'll make a patch..

But I have one (final?) question. Since I am sometimes stuck to 80x25 console...
 can we alphabetically sort the blacklist by the Vendor (the first field), instead of the quirk field(last field)?
Or is there a technical/theoretical reason behind it?   

Thanks,
	Chr.

Re: Cleaning up the USBHID's blacklist.

[Jiri Kosina]

On Tue, 31 Jul 2007, Chr wrote:

> But I have one (final?) question. Since I am sometimes stuck to 80x25 
> console...
>  can we alphabetically sort the blacklist by the Vendor (the first 
> field), instead of the quirk field(last field)? Or is there a 
> technical/theoretical reason behind it?

I find the blacklist sorted by quirk type more convenient - we typically 
want to know "who has this particular quirk", but we generally don't care 
"what quirks does this particular vendor have".

-- 
Jiri Kosina

Re: [PATCH] usbhid: add ASUS LCM to the blacklist

[Chr]

On Thursday, 11. October 2007, Javier Bolaños Molina wrote:
> Hi all,
> [...]
> Well I installed this patch, recompiled my kernel and tried again asusoled
> application in order to test the oled display.
> First time everything seemed as usual as it was with a standard (no patched)
> kernel, asusolded ask me to rmmod  usbhid as it was not able to get control
> on the oled.
> Then I removed the usbhid and tried again, it worked. Nothing new.
> After this I loaded usbhid in order to use my mouse.
> then I tried asusoled  and  fortunately this time it worked  this time with
> usbhid loaded.
> 
> To sum up the patch works fine once I remove and load usbhid once. I tend to
> think this could be a bootstrap bug as it does work well after a manual
> reload of usbhid.
> 

hmm, sounds like the old usbhid module is still around... 
My first guess: Do you use a initrd? Have you updated it, after you recompiled your kernel?

> [...]
> PS.
> I don't know  German so it was difficult to understand the page in
> https://zockertown.de/s9y/archives/882-asusoled-compilieren.html so I would
> suggest to update https://launchpad.net/asusoled/ maybe I could help.
> 
> Regards,
> Javier Bolaños Molina.
> 

The project moved to sourceforge.net. The new maintainer is:

Adilson Oliveira <adilson@linuxembarcado.com.br>

Thanks,
	Chr.