From: Paul Mundt <lethal@linux-sh.org>
To: Adrian McMenamin <lkmladrian@gmail.com>
Cc: "Antonino A. Daplas" <adaplas@gmail.com>,
linux-kernel@vger.kernel.org,
Ondrej Zajicek <santiago@crfreenet.org>
Subject: Re: [PATCH] Framebuffer: Consolidated cleanup of pvr2fb.c for Sega Dreamcast
Date: Tue, 31 Jul 2007 04:48:54 +0900 [thread overview]
Message-ID: <20070730194854.GA29181@linux-sh.org> (raw)
In-Reply-To: <8b67d60707281739l6fc544e9k5eb130ab6e426ad2@mail.gmail.com>
On Sun, Jul 29, 2007 at 01:39:51AM +0100, Adrian McMenamin wrote:
> This patch consolidates your earlier patch, some cleanup of the
> documentation and, crucially, some better handling of the pvr2
> registers based on more up to date information.
>
> Testing shows that it seems to work pretty well at 16bpp, 24bpp and
> 32bpp - including proper rendering of the boot logo at all levels
> (previously this was a bit broken even at 16bpp) and giving white
> against black text. Really detailed testing (eg with X11) requires
> support for the maple bus - which isn't (currently - next project
> assuming this is okay) available, but I have no reason to think this
> is broken.
>
> Incidentally, substituing DIRECTCOLOR for TRUECOLOR appears to break the driver.
>
> Signed-off by: Adrian McMenamin <adrian@mcmen.demon.co.uk>
This looks fine to me in any event. I can either wrap this up in my tree
or Tony can include it with his next set of updates if he has any other
concerns. Thanks, Adrian.
Acked-by: Paul Mundt <lethal@linux-sh.org>
next prev parent reply other threads:[~2007-07-30 19:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-29 0:39 [PATCH] Framebuffer: Consolidated cleanup of pvr2fb.c for Sega Dreamcast Adrian McMenamin
2007-07-29 0:45 ` Adrian McMenamin
2007-07-30 19:48 ` Paul Mundt [this message]
2007-07-30 23:55 ` Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070730194854.GA29181@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=adaplas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkmladrian@gmail.com \
--cc=santiago@crfreenet.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox