Re: [PATCH] Framebuffer: Consolidated cleanup of pvr2fb.c for Sega Dreamcast

Paul Mundt
2007-07-30T19:49:48Z

On Sun, Jul 29, 2007 at 01:39:51AM +0100, Adrian McMenamin wrote:
> This patch consolidates your earlier patch, some cleanup of the
> documentation and, crucially, some better handling of the pvr2
> registers based on more up to date information.
>
> Testing shows that it seems to work pretty well at 16bpp, 24bpp and
> 32bpp - including proper rendering of the boot logo at all levels
> (previously this was a bit broken even at 16bpp) and giving white
> against black text. Really detailed testing (eg with X11) requires
> support for the maple bus - which isn't (currently - next project
> assuming this is okay) available, but I have no reason to think this
> is broken.
>
> Incidentally, substituing DIRECTCOLOR for TRUECOLOR appears to break the driver.
>
> Signed-off by: Adrian McMenamin <adrian@mcmen.demon.co.uk>

This looks fine to me in any event. I can either wrap this up in my tree
or Tony can include it with his next set of updates if he has any other
concerns. Thanks, Adrian.

Acked-by: Paul Mundt <lethal@linux-sh.org>