From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940078AbXG3W3x (ORCPT ); Mon, 30 Jul 2007 18:29:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S969426AbXG3W2l (ORCPT ); Mon, 30 Jul 2007 18:28:41 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:54344 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S969396AbXG3W2k (ORCPT ); Mon, 30 Jul 2007 18:28:40 -0400 Date: Tue, 31 Jul 2007 00:28:19 +0200 From: Adrian Bunk To: James.Bottomley@SteelEye.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [2.6 patch] drivers/scsi/imm.c: fix check-after-use Message-ID: <20070730222819.GF3972@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org The Coverity checker spotted that we have already oops'ed if "cmd" was NULL. Since "cmd" being NULL doesn't seem to be possible at this point this patch removes the NULL check. Signed-off-by: Adrian Bunk --- --- linux-2.6.23-rc1-mm1/drivers/scsi/imm.c.old 2007-07-30 13:58:00.000000000 +0200 +++ linux-2.6.23-rc1-mm1/drivers/scsi/imm.c 2007-07-30 13:58:24.000000000 +0200 @@ -740,10 +740,6 @@ static void imm_interrupt(struct work_st struct Scsi_Host *host = cmd->device->host; unsigned long flags; - if (!cmd) { - printk("IMM: bug in imm_interrupt\n"); - return; - } if (imm_engine(dev, cmd)) { schedule_delayed_work(&dev->imm_tq, 1); return;