Re: [-mm patch] DMA engine kconfig improvements

Adrian Bunk
2007-08-10T00:44:10Z

On Fri, Aug 03, 2007 at 07:15:31PM -0700, Dan Williams wrote:
> On 7/25/07, Adrian Bunk <bunk@stusta.de> wrote:
> > On Wed, Jul 25, 2007 at 04:03:04AM -0700, Andrew Morton wrote:
> > >...
> > > Changes since 2.6.22-rc6-mm1:
> > >...
> > > +dma-arch-fix.patch
> > >
> > > Fix git-dma.patch
> > >...
> >
> > This results in an ARM-only driver in an X86-only menu...
> >
> > What about the patch below instead that also improves a few other things?
> I like it, just a few nits:
>
> > -menu "DMA Engine support"
> > - depends on HAS_DMA
> > +menuconfig DMADEVICES
> > + bool "DMA Engine support"
> > + depends on (PCI && X86) || ARCH_IOP32X || ARCH_IOP33X || ARCH_IOP13XX
> > + help
> > + Intel(R) DMA engines
> > +
> Perhaps we should go ahead and define ARCH_HAS_DMA_OFFLOAD and have
> DMADEVICES depend on that option. A ppc32 driver is in the works:
> http://marc.info/?l=linux-raid&m=117400143317440&w=2
>...

That would be overkill - what my patch does here is just a minor
cosmetical thing that could be dropped if it would become a problem.

> Regards,
> Dan (for Shannon while he is on vacation)

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed