Re: [PATCH] add check do_direct_IO() return val

Andrew Morton
2007-07-30T20:53:44Z

On Sat, 28 Jul 2007 11:47:19 +0800
Joe Jin <joe.jin@oracle.com> wrote:

> > I tested Andrew's patch and panic was gone but got few ENOTBLK.
> > So I tried with Joe's patch , both panic and ENOTBLK are gone now.
> > But in Joe's patch if (ret == -ENOTBLK && (rw & WRITE)), dio_cleanup(dio)
> > was not getting called because of break. So I moved dio_cleanup just
> > after if (ret).
>
> Guru, actually, break from the loop with ENOTBLK will call dio_cleanup
> at leater, if call it too early, that means will put_page(), maybe cause
> other panic.
>

fyi, I dropped the earlier patch and now we have nothing. Please let's get all
this sorted out in time for 2.6.23. Which is still many weeks away so there is
plenty of time to prepare something which was carefully reviewed and well-tested,
thanks.