From: Andi Kleen <ak@novell.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: akpm@linux-foundation.org, Yinghai Lu <yhlu.kernel@gmail.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Chandramouli Narayanan <mouli@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] x86_64 EFI support -v3: EFI boot support
Date: Wed, 1 Aug 2007 14:56:21 +0200 [thread overview]
Message-ID: <200708011456.21768.ak@novell.com> (raw)
In-Reply-To: <1185958748.1363.40.camel@caritas-dev.intel.com>
>
> Should I change "change_page_attr" to make it work before "mem_init"? Or
> Should I change "init_memory_mapping" to make it can be used to change
> mapping attributes? Which one is better?
It's probably better to change init_memory_mapping. Just do it cleanly
and correctly please. As in only change the pages that straddle the
EFI areas and don't use globals.
BTW i don't see any such code on i386. How does the EFI support
there handle it?
-Andi
prev parent reply other threads:[~2007-08-01 12:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-31 3:12 [PATCH 2/5] x86_64 EFI support -v3: EFI boot support Huang, Ying
2007-07-31 11:35 ` Andi Kleen
2007-08-01 8:59 ` Huang, Ying
2007-08-01 12:56 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708011456.21768.ak@novell.com \
--to=ak@novell.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mouli@linux.intel.com \
--cc=randy.dunlap@oracle.com \
--cc=yhlu.kernel@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox