From: Andrew Morton <akpm@linux-foundation.org>
To: "Keshavamurthy, Anil S" <anil.s.keshavamurthy@intel.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>, Andi K <ak@suse.de>,
arjan <arjan@linux.intel.com>, Ashok Raj <ashok.raj@intel.com>,
Suresh B <suresh.b.siddha@intel.com>
Subject: Re: [patch -mm][Intel-IOMMU] Optimize sg map/unmap calls
Date: Wed, 1 Aug 2007 16:45:54 -0700 [thread overview]
Message-ID: <20070801164554.5d2d157a.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070801200623.GA20780@linux-os.sc.intel.com>
On Wed, 1 Aug 2007 13:06:23 -0700
"Keshavamurthy, Anil S" <anil.s.keshavamurthy@intel.com> wrote:
> +/* Computes the padding size required, to make the
> + * the start address naturally aligned on its size
> + */
> +static int
> +iova_get_pad_size(int size, unsigned int limit_pfn)
> +{
> + unsigned int pad_size = 0;
> + unsigned int order = ilog2(size);
> +
> + if (order)
> + pad_size = (limit_pfn + 1) % (1 << order);
> +
> + return pad_size;
> +}
This isn't obviously doing the right thing for non-power-of-2 inputs.
ilog2() rounds down...
Please check that this, and all the other ilog2()s which have been added
are doing the right thing if they can be presented with non-power-of-2
inputs?
next prev parent reply other threads:[~2007-08-01 23:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 20:06 [patch -mm][Intel-IOMMU] Optimize sg map/unmap calls Keshavamurthy, Anil S
2007-08-01 23:45 ` Andrew Morton [this message]
2007-08-02 17:25 ` Keshavamurthy, Anil S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070801164554.5d2d157a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ak@suse.de \
--cc=anil.s.keshavamurthy@intel.com \
--cc=arjan@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox