From: Andrew Morton <akpm@linux-foundation.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: LKML <linux-kernel@vger.kernel.org>,
Nigel Cunningham <nigel@nigel.suspend2.net>,
Oleg Nesterov <oleg@tv-sign.ru>, Pavel Machek <pavel@ucw.cz>,
pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH -mm 3/3] Freezer: Measure freezing time
Date: Wed, 1 Aug 2007 16:53:33 -0700 [thread overview]
Message-ID: <20070801165333.7f93c4a6.akpm@linux-foundation.org> (raw)
In-Reply-To: <200708012336.40388.rjw@sisk.pl>
On Wed, 1 Aug 2007 23:36:39 +0200
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> + do_gettimeofday(&end);
> + elapsed_csecs64 = timeval_to_ns(&end) - timeval_to_ns(&start);
> + do_div(elapsed_csecs64, NSEC_PER_SEC / 100);
> + elapsed_csecs = elapsed_csecs64;
I'd have thought that we had enough timeval library code by now to
not need to open-code things like this.
<looks around>
No, it seems that we don't. So people keep on open-coding the same
thing, or inventing private code which shouldn't be.
<notices net/dccp/dccp.h>
What the hell is all that stuff doing in there?
prev parent reply other threads:[~2007-08-01 23:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 21:28 [PATCH -mm 0/3] Freezer: Use wait queue instead of busy looping Rafael J. Wysocki
2007-08-01 21:30 ` [PATCH -mm 1/3] Freezer: Be more verbose Rafael J. Wysocki
2007-08-01 21:32 ` [PATCH -mm 2/3] Freezer: Use wait queue instead of busy looping Rafael J. Wysocki
2007-08-01 23:48 ` Andrew Morton
2007-08-02 11:15 ` Rafael J. Wysocki
2007-08-02 17:38 ` [PATCH -mm 2/3] Freezer: Use wait queue instead of busy looping (updated) Rafael J. Wysocki
2007-08-02 18:40 ` Oleg Nesterov
2007-08-02 21:13 ` Rafael J. Wysocki
2007-08-02 21:23 ` Oleg Nesterov
2007-08-02 21:49 ` Rafael J. Wysocki
2007-08-02 22:05 ` Oleg Nesterov
2007-08-01 21:36 ` [PATCH -mm 3/3] Freezer: Measure freezing time Rafael J. Wysocki
2007-08-01 23:53 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070801165333.7f93c4a6.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=nigel@nigel.suspend2.net \
--cc=oleg@tv-sign.ru \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox